Skip to content

Conversation

addshore
Copy link
Collaborator

@addshore addshore commented Sep 2, 2022

Not tested yet, but in principle the sync already works, as
we have a job that runs a diff to disallow merging.
So as long as the commit action works this should work.

I wrote this as I am using mobile data and don't want to run
it all locally...

Not tested yet, but in principle the sync already works, as
we have a job that runs a diff to disallow merging.
So as long as the commit action works this should work.

I wrote this as I am using mobile data and don't want to run
it all locally...
@addshore
Copy link
Collaborator Author

addshore commented Sep 2, 2022

I would plan on running this on #276
But to do that it would already need to be merged into main I believe.

@addshore addshore marked this pull request as ready for review September 2, 2022 10:49
@tarrow
Copy link
Contributor

tarrow commented Sep 6, 2022

Like the concept but not sure I love the implementation. I would feel more confident if this opened a PR (even to not-main) and then we manually merged it

@addshore
Copy link
Collaborator Author

addshore commented Sep 6, 2022

Like the concept but not sure I love the implementation. I would feel more confident if this opened a PR (even to not-main) and then we manually merged it

Shouldn't be too hard to rework it to do that!
I'll take a look

@addshore
Copy link
Collaborator Author

addshore commented Sep 6, 2022

per the comment in the file, a permission is needed to create PRs, but this is already enabled on this repository

@addshore addshore requested a review from tarrow September 6, 2022 15:18
@tarrow
Copy link
Contributor

tarrow commented Sep 11, 2022

Seems like the easiest way to test this is to merge it... let's go ahead

1 similar comment
@tarrow
Copy link
Contributor

tarrow commented Sep 11, 2022

Seems like the easiest way to test this is to merge it... let's go ahead

@tarrow tarrow merged commit 1f28877 into main Sep 11, 2022
@tarrow tarrow deleted the sync-via-github-actions-trigger branch September 11, 2022 14:14
@addshore
Copy link
Collaborator Author

Happy to report success #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants