local: fix IP block #481
Open
local: fix IP block #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
May 28, 2025
|
|
||
| // Define some conditions to switch behaviour on | ||
| $wwDomainSaysLocal = preg_match("/(\w\.localhost)/", $_SERVER['SERVER_NAME']) === 1; | ||
| $wwDomainSaysLocal = preg_match("/(\w\.wbaas\.dev)/", $_SERVER['SERVER_NAME']) === 1; |
There was a problem hiding this comment.
this probably needs an "or" or i think this will break and docker usages of this flag
There was a problem hiding this comment.
I updated it, although I'm not sure if the docker stuff uses something.localhost domains (as this regex also didnt include just localhost before, but at least it shouldnt break anything additionally now)
tarrow
force-pushed
the
de/fix-spamblock
branch
from
7815f41 to
55804bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like some DNS IP blocklist added the private IP range that our minikube setup uses (
10.244.0.1/16)Unfortunately we can't set that range directly in $wgProxyWhitelist so I added some loops to build up the IP list ... hopefully we can find a nicer solution but this seems to work at least, so I record it here as a workaround.
Also this fixes
$wwDomainSaysLocalas we do not use localhost domains anymore.