fix: use native plugin to handle hashbang and react directives #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
force-pushed
the
hashbang
branch
2 times, most recently
from
b0ff1b8 to
65a2f10
Compare
2 tasks
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework
force-pushed
the
hashbang
branch
6 times, most recently
from
3b2dc19 to
1b8e9a0
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Copilot finished reviewing on behalf of
fi3ework
November 19, 2025 06:45
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors hashbang (#!) and React directive handling by delegating them to Rspack's native plugin instead of handling them in the Rslib loader/plugin. The change simplifies the codebase and leverages native functionality.
Key Changes
- Removed hashbang and React directive handling logic from
EntryChunkPluginandentryModuleLoader - Added
directives: falseto minify configuration to preserve directive prologues - Made entry module loader conditional based on
advancedEsmflag - when enabled, no loader is needed
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/entryModuleLoader.ts | Simplified to empty pass-through loader for creating entry module doppelganger |
| packages/core/src/plugins/EntryChunkPlugin.ts | Removed shebang/directive handling logic and related state tracking; added useLoader parameter |
| packages/core/src/constant.ts | Removed unused shebang and React directive constants |
| packages/core/src/config.ts | Added directives: false to minify config and conditional loader usage based on advancedEsm |
| tests/integration/directive/react/bundleless/rslib.config.ts | Added minify configuration with comment explaining directives: false option |
| tests/integration/directive/index.test.ts | Updated test expectations to match native plugin output format (double quotes, preserved directives) |
| tests/integration/entry/index.test.ts | Updated snapshots for new chunk organization with advancedEsm |
| tests/integration/shims/index.test.ts | Made regex pattern more flexible to handle dynamic chunk IDs |
| packages/core/tests/config.test.ts | Updated test snapshot to include directives: false |
| packages/core/tests/snapshots/config.test.ts.snap | Updated all snapshots to reflect removed directive handling and added minify option |
| pnpm-lock.yaml | Bumped @rspack/plugin-react-refresh from 1.5.2 to 1.5.3 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #316.
in this PR:
depends on depends on web-infra-dev/rspack#12168, the native Rslib plugin has handled hashbang and react directives.
with
advancedEsmno entry dedicated loader anymore,
advancedEsmcan handle "the issue of a module acting as both an entry module and a non-entry module is that the module graph can affect each other".without
advancedEsmstill using a dedicated loader, but only an empty loader to make the doppelganger. the loader will not handle hashbang and react directives anymore (already handled in native plugin).
Related Links
Checklist