Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ecosystem-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ permissions:
# Allow commenting on pull requests
pull-requests: write

env:
# we are going to build release profile for benchmark
CARGO_INCREMENTAL: 1
jobs:
build:
name: Test Linux
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-build-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
env:
# Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
# https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
CARGO_INCREMENTAL: 0
CARGO_INCREMENTAL: 1

permissions:
# Allow commenting on issues
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/reusable-build-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
env:
# Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
# https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
CARGO_INCREMENTAL: 0
CARGO_INCREMENTAL: 1

jobs:
build:
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Install Rust Toolchain
uses: ./.github/actions/rustup
with:
key: ${{ inputs.target }}-${{ inputs.profile }}
key: ${{ inputs.target }}-${{ inputs.profile }}-pshu-1-${{ inputs.prefer_docker == 'true' && 'docker' || 'native' }}
# don't need use cache in self-hosted windows; benefits of build with cargo build are wasted by cache restore
save-if: true

Expand Down Expand Up @@ -92,7 +92,9 @@ jobs:
if: ${{ inputs.target == 'x86_64-unknown-linux-gnu' && !inputs.prefer_docker }}
run: |
rustup target add x86_64-unknown-linux-gnu
RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:${{ inputs.profile }}
CARGO_INCREMENTAL=1 RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:${{ inputs.profile }}

- uses: ./.github/actions/debugger

- name: Build x86_64-unknown-linux-gnu in Docker
if: ${{ inputs.target == 'x86_64-unknown-linux-gnu' && inputs.prefer_docker }}
Expand Down
1 change: 1 addition & 0 deletions crates/node_binding/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ async function build() {
"--no-js",
// "--no-const-enum",
"--no-dts-header",
"-v",
"--pipe",
`"node ${path.resolve(__dirname, "dts-header.js")}"`
];
Expand Down
Loading