-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early customizable select feature #2301
base: main
Are you sure you want to change the base?
Conversation
One obvious problem with creating this early feature is the lack of official spec. I think the most official artefact we have for this feature is the explainer on openui.org, which is what I've used for now, but which breaks the build. |
@@ -0,0 +1,11 @@ | |||
name: Customizable <select> | |||
description: The `<select>` element's appearance, including the button, selected option, picker dropdown, and options, can be customized using CSS. | |||
spec: https://open-ui.org/components/customizableselect/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link should be updated to https://open-ui.org/components/customizableselect/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same link that's already there in the file?
Chromium I2S is out: https://groups.google.com/a/chromium.org/g/blink-dev/c/kN5LTzuTLVs/m/6HqTsmk3EQAJ |
@ddbeck I think we should merge this pretty much as is, allowing the OpenUI explainer URL. Customizable select has been in the works for many years, it needs to exist on our repo. We can use this as a guinea pig for early features if we want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, but before merging, I'd like the spec link exception to point at something that'll tell us when the specification story is resolved.
], | ||
[ | ||
"https://open-ui.org/components/customizableselect/", | ||
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good issue or PR to link to that would prompt us to remove this exception? Basically, I want to know where to look when we have "real" spec links to replace this with.
Something like this?
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment." | |
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment. Remove when SOMEURL merges." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple PRs, not just one. See my previous comment: #2301 (comment)
Out of those, I'm guessing it would be enough to link to the following ones:
whatwg/html#10586
whatwg/html#10629
whatwg/html#10633
@josepharhar are you able to help select one (or more, but ideally a small number) spec PR that would basically signify "that's it, customizable select is now in the spec"?
Superseded by web-platform-dx#2301
* Remove selectlist feature Superseded by #2301 * Remove scroll-marker draft This looks premature, particularly without a process for early features.
Customizable select has been in discussions and in various states of prototypes for a few years already. It's feeling like the proposal is stabilizing now, and the feature has reached WHATWG stage 2 (soon stage 3). See this developer.chrome.com blog about it.
We've talked about how some (most?) features might need to get created early in the making, and I wanted to see what it felt like for this one.
@SachaG had asked for it in the past, in order to be able to link to it from State of HTML, where it's mentioned.