Migrate next-tagged releases to trusted publishing
#3582
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools and infrastructure
ddbeck
force-pushed
the
trusted-publishing
branch
from
c651ce1 to
6b15303
Compare
ddbeck
commented
Nov 26, 2025
Collaborator
Author
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Self-reviewing to provide some clarity to would-be reviewers.
Comment on lines
+10
to
+11
| permissions: {} | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
The permissions vary between jobs here, so this explicitly unsets them for the workflow.
Comment on lines
-70
to
-74
| - if: ${{ env.NODE_AUTH_TOKEN }} | ||
| run: npm publish --tag ${{ env.dist_tag }} | ||
| - run: npm publish --tag ${{ env.dist_tag }} | ||
| working-directory: ${{ env.package_dir }} | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
Collaborator
Author
There was a problem hiding this comment.
The token is no longer required (and the if condition was superfluous anyway, in light of the if: github.repository … condition for the entire job).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub and npm are moving to a package publishing model that uses OIDC instead of npm tokens. If we switch to this, we would not need to periodically reissue tokens (as described in our publishing docs). This was inspired by me having to reissue tokens today.
This PR migrates the
compute-baselineandweb-featuresnext-tagged releases to this publishing workflow. If this works well, we can refactor thelatest-tagged publishing workflows to use the same method ((un)fortunately, each package on npm may only have one blessed workflow, so we'll have to consolidate the publishing workflows).Upon merging, the packages need configuration in npmjs.com (see this section of the npm docs and this area in the npm UI, if you have access). If you're not ready to do this yourself, then please approve and leave unmerged. Thank you!