sensors: Do nothing in Sensor.start() when the document is not fully active. #32514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 24, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3412476
branch
from
114c18b to
5adc7a5
Compare
…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#962930}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3412476
branch
from
5adc7a5 to
3011a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sensor is created on e.g. an iframe that is later removed from
its parent via removeChild(), we end up in a situation where a sensor
instance did get created but which does not have a valid
ExecutionContext by the time start() is invoked.
Check for a valid ExecutionContext when start() is called and bail out
early if it is null. w3c/sensors#415 tracks
handling non-fully active documents from a spec perspective; once that
one is fixed we should probably throw an error in this case rather than
silently doing nothing.
Bug: 1289924
Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Raphael Kubo Da Costa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#962930}