Skip to content

Commit cfdffc0

Browse files
calien666sbuerk
authored andcommitted
[TASK] Remove superfluous Hook
The TCEmainHook.php was intentionally added allowing the override of the cmdMap array inside the DataHandler. As this was in older versions bad practice and the DataHandler hardening in v13 enforced `deepltranslate-core` introducing an own translation command as best practice, the hook allowing `localization` inside the cmdMap array is superfluous.
1 parent 159b3ac commit cfdffc0

File tree

3 files changed

+3
-34
lines changed

3 files changed

+3
-34
lines changed

Classes/Configuration.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44

55
namespace WebVision\Deepltranslate\Core;
66

7+
use Symfony\Component\DependencyInjection\Attribute\AsAlias;
78
use TYPO3\CMS\Backend\Utility\BackendUtility;
89
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
910
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
1011
use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
11-
use TYPO3\CMS\Core\SingletonInterface;
1212
use TYPO3\CMS\Core\Utility\GeneralUtility;
1313

14-
final class Configuration implements ConfigurationInterface, SingletonInterface
14+
#[AsAlias(id: ConfigurationInterface::class, public: true)]
15+
final class Configuration implements ConfigurationInterface
1516
{
1617
private string $apiKey = '';
1718

Classes/Hooks/TCEmainHook.php

Lines changed: 0 additions & 28 deletions
This file was deleted.

ext_localconf.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@
1919
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['processCmdmapClass'][\WebVision\Deepltranslate\Core\Hooks\UsageProcessAfterFinishHook::class]
2020
= \WebVision\Deepltranslate\Core\Hooks\UsageProcessAfterFinishHook::class;
2121

22-
//hook to checkModifyAccessList for editors
23-
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['checkModifyAccessList']['deepl']
24-
= \WebVision\Deepltranslate\Core\Hooks\TCEmainHook::class;
25-
2622
//xclass localizationcontroller for localizeRecords() and process() action
2723
$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'][\TYPO3\CMS\Backend\Controller\Page\LocalizationController::class] = [
2824
'className' => \WebVision\Deepltranslate\Core\Override\LocalizationController::class,

0 commit comments

Comments
 (0)