Skip to content

Replace bincode with rkyv 0.8.15 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 9 commits into from
Mar 13, 2026
Merged

Replace bincode with rkyv 0.8.15 #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e57c69
Replace bincode with rkyv 0.8.15
genedna Mar 13, 2026
0c07cc5
Declare rkyv bytecheck feature explicitly
genedna Mar 13, 2026
87c761f
Harden pack cache spill format handling
genedna Mar 13, 2026
7831129
Fix rustfmt formatting in cache spill code
genedna Mar 13, 2026
d498921
Harden atomic cache spill writes
genedna Mar 13, 2026
f8f77f9
Refine pack cache spill review fixes
genedna Mar 13, 2026
50a34c8
Avoid clobbering existing pack cache files
genedna Mar 13, 2026
67d353a
Skip redundant pack cache re-encoding
genedna Mar 13, 2026
a8b7608
Align pack cache spill save and tests
genedna Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ rust_library(
"//third-party/rust/crates/ahash/0.8.12:ahash",
"//third-party/rust/crates/async-trait/0.1.89:async-trait",
"//third-party/rust/crates/axum/0.8.8:axum",
"//third-party/rust/crates/bincode/2.0.1:bincode",
"//third-party/rust/crates/bstr/1.12.1:bstr",
"//third-party/rust/crates/byteorder/1.5.0:byteorder",
"//third-party/rust/crates/bytes/1.11.1:bytes",
Expand All @@ -52,6 +51,7 @@ rust_library(
"//third-party/rust/crates/path-absolutize/3.1.1:path-absolutize",
"//third-party/rust/crates/rayon/1.11.0:rayon",
"//third-party/rust/crates/ring/0.17.14:ring",
"//third-party/rust/crates/rkyv/0.8.15:rkyv",
"//third-party/rust/crates/sea-orm/1.1.19:sea-orm",
"//third-party/rust/crates/serde/1.0.228:serde",
"//third-party/rust/crates/serde_json/1.0.149:serde_json",
Expand Down
163 changes: 121 additions & 42 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ serde = { version = "1.0.228", features = ["derive"] }
chrono = { version = "0.4.44", features = ["serde"] }
uuid = { version = "1.22.0", features = ["serde", "v4", "v7"] }
tokio = { version = "1.50.0", features = ["fs", "io-util"] }
bincode = { version = "2.0.1", features = ["serde"] }
rkyv = { version = "0.8.15", features = ["bytecheck"] }
axum = { version = "0.8.8", features = ["macros", "json"] }

[dev-dependencies]
Expand Down
16 changes: 11 additions & 5 deletions buckal.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
version = 2

[fingerprints]
"path+file://($WORKSPACE)#0.7.0" = "43cc83fd3f8b5f2e7ca904ae05cbc9215d8d66e741d114b25d302f71a9e3b94c"
"path+file://($WORKSPACE)#0.7.0" = "1fb44fb313a5a9a2781cd7295d057c7588363868554d5ed7387b46b0b6db76fc"
"registry+https://github.com/rust-lang/crates.io-index#adler2@2.0.1" = "7081ce7693ca45bff0e855374e6b7f386805bba1de9f7c288b1c706b99abef7f"
"registry+https://github.com/rust-lang/crates.io-index#ahash@0.7.8" = "263bbc26dec8ade458658cf9dae3ef8fc606e85f04c7b47abb4f9255319689ac"
"registry+https://github.com/rust-lang/crates.io-index#ahash@0.8.12" = "a383722a12d8343396b1965bfe77f1cebeafb12ccc571747b2b54614e3e1a1ea"
Expand All @@ -25,8 +25,6 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#base64@0.22.1" = "515d0850a06d4dec36805d42bfd7cb6c8d287e894b16cf7ded43a3d1cdd98192"
"registry+https://github.com/rust-lang/crates.io-index#base64ct@1.8.1" = "866a57dd8efb8c621bdf0d32f62488792eb50f0dcdf9374d1abc7a7a77d48182"
"registry+https://github.com/rust-lang/crates.io-index#bigdecimal@0.4.9" = "f88bba28db672a65c61e84f5a91f481f570167555da21311619efea9efe3e4c5"
"registry+https://github.com/rust-lang/crates.io-index#bincode@2.0.1" = "c91b070a3a9668d0fe974d9525a85ae815338ac61d5097b5e8c6bff1f681ee76"
"registry+https://github.com/rust-lang/crates.io-index#bincode_derive@2.0.1" = "c8f177b67811abc8f1afb1461a99441f9c3d27323cffed8957d9d765368697f5"
"registry+https://github.com/rust-lang/crates.io-index#bindgen@0.72.1" = "74d11d9944796413a022cf77d866b0cdd0ca26ba33c4a581c88338211f3f9504"
"registry+https://github.com/rust-lang/crates.io-index#bitflags@2.10.0" = "d42a9d45fc396e87228b696c85657ce020419db6ceb6de8080b05b4b9fdc913a"
"registry+https://github.com/rust-lang/crates.io-index#bitvec@1.0.1" = "dca0faeeba20245839115b4769219915d84fc18c99f9b0111faa6114bad5eec2"
Expand All @@ -37,7 +35,9 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#bstr@1.12.1" = "a8e3b544859f816c7e1f003ad685fb57a215996d6b24c6f1ed830fa43383180a"
"registry+https://github.com/rust-lang/crates.io-index#bumpalo@3.19.0" = "b61fb56f898b27098f1ce33023e19e683996197a1e5dc7459a6e8105625be66b"
"registry+https://github.com/rust-lang/crates.io-index#bytecheck@0.6.12" = "cc1c82108a15bfd9498f5e283fc52b0aa9ce22f82a010fe98960b5b3ee240e80"
"registry+https://github.com/rust-lang/crates.io-index#bytecheck@0.8.2" = "fa4a5bbc0e835970cfad6879ca949e96cf2603437b53c9194c4a3638a1d031b2"
"registry+https://github.com/rust-lang/crates.io-index#bytecheck_derive@0.6.12" = "8b0c10e17c673205907d056bd4e31e3d89420ca4235e61c243a8892ebd295e77"
"registry+https://github.com/rust-lang/crates.io-index#bytecheck_derive@0.8.2" = "4df8e62ef9290647056eb9b39dab88a9a6c53321276e01689dadf0ef404171f4"
"registry+https://github.com/rust-lang/crates.io-index#byteorder@1.5.0" = "759111df9ebe307cd1672921dd3a4f812a3a8fb2332bd830dd203ad528986268"
"registry+https://github.com/rust-lang/crates.io-index#bytes@1.11.1" = "328316eb40f355e38e2f3ce3500b54390c55d1b69000bfe3a0e7483d52c0bd9c"
"registry+https://github.com/rust-lang/crates.io-index#cc@1.2.49" = "a5fe9f33632d99e0bd2a6dac517ce1e8ba84b3133535819a6ec81000ed54b58b"
Expand Down Expand Up @@ -161,6 +161,8 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#minimal-lexical@0.2.1" = "8094ff1242ec4361f3e4a095c00361eae5975e5bffa058e8d372f8c9c0f952f7"
"registry+https://github.com/rust-lang/crates.io-index#miniz_oxide@0.8.9" = "886746246ee7815375aee39029630fe4c34885a6c117fec279ac1ba3ca09d0ca"
"registry+https://github.com/rust-lang/crates.io-index#mio@1.1.1" = "22bc7a128507a58764ee1b52d83f9ce7d6c080014b6a7fc6a571944ec15e6876"
"registry+https://github.com/rust-lang/crates.io-index#munge@0.4.7" = "f8c29089bd73db4a79b78cb0a74d74884e9d839fea63cfac2c9fee17e7ca0f12"
"registry+https://github.com/rust-lang/crates.io-index#munge_macro@0.4.7" = "f2acb587393837bf81b8c8c41038818b443dcc5efa3a2e6738baf11cc4a40815"
"registry+https://github.com/rust-lang/crates.io-index#natord@1.0.9" = "c0227b24bcf1d15d97f25673ede276e2903ff6d31017d1be062a7a7b94599d05"
"registry+https://github.com/rust-lang/crates.io-index#nom@7.1.3" = "a89f137cca41a2c803b582c5dc34193da86ceb9f2c3fdec6579cac083500bc3c"
"registry+https://github.com/rust-lang/crates.io-index#nu-ansi-term@0.50.3" = "414b7230f93019dee6d24b817afcb96bf8eb0d2ea2ee4b830e5635d4bf3111bd"
Expand Down Expand Up @@ -198,11 +200,14 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#proc-macro2-diagnostics@0.10.1" = "87fc4d745d36a9bb32fbff2bc98f0c5431df0d53610a8219a3ce05fc1308b57d"
"registry+https://github.com/rust-lang/crates.io-index#proc-macro2@1.0.103" = "9b25ba05e80fc659ff7d42f3d5606545aa8d189a21ef05aee1ad690ffa036123"
"registry+https://github.com/rust-lang/crates.io-index#ptr_meta@0.1.4" = "a39cc9491aa20110894b613d62277e1d61df7a0d658e5228bd8657237cb04ad7"
"registry+https://github.com/rust-lang/crates.io-index#ptr_meta@0.3.1" = "54f0229311d4d496bf4eea9ca0d3e998e66d9250d8b48eebd03e5a93e53818fc"
"registry+https://github.com/rust-lang/crates.io-index#ptr_meta_derive@0.1.4" = "9eb2472593a4173aba6a3c61291dd156933072eb2822ae7a1c9fdbae3461a1fc"
"registry+https://github.com/rust-lang/crates.io-index#ptr_meta_derive@0.3.1" = "e98c7436cd8a276511893accbf5e05d17da676604a855a8ab2c3d002998b4e3e"
"registry+https://github.com/rust-lang/crates.io-index#quickcheck@1.1.0" = "fc3b0759c2206ac5c6fe56270efde7fe7e0cc8ce6c755ba8c7f5b4e476f63999"
"registry+https://github.com/rust-lang/crates.io-index#quote@1.0.42" = "91c8d87ed79d624a31a96de45ffb568d706c6d680d9b059666c790d6b8df9a42"
"registry+https://github.com/rust-lang/crates.io-index#r-efi@5.3.0" = "8b782f8b39e0573e49058548a27f0982ac72a7029326d2bc61b6df3c194cffaa"
"registry+https://github.com/rust-lang/crates.io-index#radium@0.7.0" = "52ab1f0da4ca3712c10b6f2268313ee3f674dace171872ca510a78e825f01b90"
"registry+https://github.com/rust-lang/crates.io-index#rancor@0.1.1" = "16a163657e06c7a7fd1a9382dfa1ef0959d50274282c75ea52d0dd8c3cba4e7f"
"registry+https://github.com/rust-lang/crates.io-index#rand@0.10.0" = "4c8d4b0559169936693413bb92d8eaef49a90de357ef12f1e52d148114d5c455"
"registry+https://github.com/rust-lang/crates.io-index#rand@0.8.5" = "e6d182df64ee06bc76df421202bdb30272fc8dedb760388ec3f86cb753954214"
"registry+https://github.com/rust-lang/crates.io-index#rand_chacha@0.3.1" = "08c84d54e52a16abda285b9ff0dc9ba53275ff0400893d18cadca9e62136117c"
Expand All @@ -215,9 +220,12 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#regex-syntax@0.8.8" = "b5bd7a8b232100b181ef43ff406fb2382e503828b02a43cd606f98d6ea0ad950"
"registry+https://github.com/rust-lang/crates.io-index#regex@1.12.2" = "e640b9d3c534b375567bffc8c9cb989938f829ec848f620da291d305f375049e"
"registry+https://github.com/rust-lang/crates.io-index#rend@0.4.2" = "e1477adda7718f5953efaa45ef12a2e30c0037c5723d544285f1d21d751a092b"
"registry+https://github.com/rust-lang/crates.io-index#rend@0.5.3" = "5cf67da2b5e904d5c60d95d27f069c786f48eb7d720d8326321d064f339996f1"
"registry+https://github.com/rust-lang/crates.io-index#ring@0.17.14" = "32b156e24bca8e85f41473b54b727f2b5e35aac99300f6c3781fb3239ba7c549"
"registry+https://github.com/rust-lang/crates.io-index#rkyv@0.7.45" = "3b6dac82b5ff286c8e17785f92161e369764979a16187de781a6e0de01db458d"
"registry+https://github.com/rust-lang/crates.io-index#rkyv@0.8.15" = "4bcb49b1540c5698e1fa3a19dacaa55b4a8d4787eb4cc5a6a1e983ff4889a74b"
"registry+https://github.com/rust-lang/crates.io-index#rkyv_derive@0.7.45" = "ad51df9d2e223d73130300a8075a8eaeed101ff95d4c9ad1252498f7186db950"
"registry+https://github.com/rust-lang/crates.io-index#rkyv_derive@0.8.15" = "69fe36a095e6613c1bb25e249a1ec4b65929acff97aa1c9d4cce1d4b512c017e"
"registry+https://github.com/rust-lang/crates.io-index#rsa@0.9.10" = "9e4146e51ce7cb3bfeca2da05259109f47b38350679c086df91d3c492e59a808"
"registry+https://github.com/rust-lang/crates.io-index#rust_decimal@1.39.0" = "b6e5be3f346b31adf8bbe736cbe3ad02b7a47a279e61338ee89625c61bb50d4e"
"registry+https://github.com/rust-lang/crates.io-index#rustc-hash@2.1.1" = "0679bb21a175710a797b96bedea9bb8d694b5c2110360190bb128ea90c196143"
Expand Down Expand Up @@ -303,14 +311,12 @@ version = 2
"registry+https://github.com/rust-lang/crates.io-index#unicode-properties@0.1.4" = "cdf6d930a0dfc1acc3b026018d97c6bf20106eaecbdf5dceb3d7aaef1b4dbeb4"
"registry+https://github.com/rust-lang/crates.io-index#unicode-xid@0.2.6" = "04c6fa64d1f26eb2c0594f87108dff265d17d747d21de7a9b240a4675ad7f2ef"
"registry+https://github.com/rust-lang/crates.io-index#untrusted@0.9.0" = "0e5f903c4d858d56b064f2e47fd2b2e6d228f9404ceeef561b5cc4c0d77bec33"
"registry+https://github.com/rust-lang/crates.io-index#unty@0.0.4" = "5475cd4e774a5dff1d71ec84f3f46bbf2a1ce7ecae45e15713335645a8e14941"
"registry+https://github.com/rust-lang/crates.io-index#url@2.5.7" = "41a06dd6e4a64931308619cd9143392e669fe55fff38850784e1a9a09b49bfc2"
"registry+https://github.com/rust-lang/crates.io-index#utf8_iter@1.0.4" = "047f25b86fd5f1351043a8dde0aeed66f85eeca3ac56cbb7bec54ed6c023b16c"
"registry+https://github.com/rust-lang/crates.io-index#uuid@1.22.0" = "9d78edb46ab75488038bd9bc89024abc587ad4c63cfb50a8451b62f933aa65f5"
"registry+https://github.com/rust-lang/crates.io-index#valuable@0.1.1" = "756ad94b5effaecf9973461517320157d1ee5ab3ec28d86e1f99c4915851a45e"
"registry+https://github.com/rust-lang/crates.io-index#vcpkg@0.2.15" = "719f7f17537403aaa321d268702fb5039de3e7c1993d88754cca070f8b597174"
"registry+https://github.com/rust-lang/crates.io-index#version_check@0.9.5" = "5f3a662254d4a2b2e505904ada0ee24aa8376f7d08d71832a6a0f1ff04f1ad71"
"registry+https://github.com/rust-lang/crates.io-index#virtue@0.0.18" = "2d1376e442772102fce8b9b6635530fb12bdecc3fd3d2a3fef3636e442469f4a"
"registry+https://github.com/rust-lang/crates.io-index#wasi@0.11.1+wasi-snapshot-preview1" = "9c7da0443e0bf7dff296b9c6a81a67964fa0290e311767101860356a664bc268"
"registry+https://github.com/rust-lang/crates.io-index#wasip2@1.0.1+wasi-0.2.4" = "66e9546d4dcc87766fd72d8d5ef9987e133d78efc6834cd9b416a019e8098ff4"
"registry+https://github.com/rust-lang/crates.io-index#wasip3@0.4.0+wasi-0.3.0-rc-2026-01-06" = "c534f9205391d698c6cc60c6bf660b07de4f4a8c8851a3bf0a7cdf43022b81d4"
Expand Down
Loading
Loading