Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: update sync server action #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: update sync server action #2030
Changes from all commits
a49d99eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matrix includes a
TODOstating the gitmono service name is not the actual one, butaws ecs update-serviceis executed unconditionally for that entry; if this placeholder does not match a real ECS service, the gitmono matrix leg fails and thedeploy-awsjob is marked failed on every run. This should be updated to the real service name before merging.Useful? React with 👍 / 👎.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API_URLis now exported directly fromprocess.env.API_URLwithout any fallback, while this commit also removes the checked-in sync-server.env.*files; in any environment whereAPI_URLis not explicitly injected, the generated client will run with an empty base URL and issue relative fetches, which breaks sync/auth requests at runtime in Node. Please keep a safe default or fail fast during startup whenAPI_URLis missing.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.