fix: improve Windows UX and complete zh-Hans translations#1
Open
YuYingRay wants to merge 10 commits into
Open
Annotations
4 errors and 1 warning
|
Run test suite
Process completed with exit code 1.
|
|
Run test suite:
tests/unit/components/settingsModal.test.jsx#L133
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Done"
Here are the accessible roles:
dialog:
Name "settings":
<div
aria-labelledby="settings-modal-title"
aria-modal="true"
class="relative flex flex-col overflow-hidden rounded-[26px] border border-white/12 text-white shadow-[0_24px_80px_rgba(0,0,0,0.62)]"
role="dialog"
style="z-index: 1; width: 62vw; min-width: 720px; max-width: 920px; height: auto; padding: 16px; background-color: rgba(28, 28, 28, 0.95); transform: translateY(8px) scale(0.985); transition: transform 200ms cubic-bezier(0.22, 1, 0.36, 1);"
/>
--------------------------------------------------
heading:
Name "settings":
<h2
class="text-[16px] font-medium"
id="settings-modal-title"
/>
--------------------------------------------------
checkbox:
Name "settingsHideAppWhenUnfocused":
<input
checked=""
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsKeepAppInTray":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsHideWindowOnLaunch":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsOpenAtLogin":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsHideDockIconWhenHidden":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsCopyingImageToClipboard":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsSavingImage":
<input
checked=""
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsSavingToFolder":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
--------------------------------------------------
combobox:
Name "":
<select
class="w-full rounded-[8px] bg-white/5 px-3 py-2 text-[13px] text-white/90 outline-none border border-white/10"
/>
--------------------------------------------------
option:
Name "English":
<option
value="en"
/>
Name "简体中文":
<option
value="zh-Hans"
/>
Name "繁體中文":
<option
value="zh-Hant"
/>
Name "한국어":
<option
value="ko"
/>
Name "Français":
<option
value="fr"
/>
Name "हिन्दी":
<option
value="hi"
/>
Name "Español":
<option
value="es"
/>
--------------------------------------------------
button:
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsResetAll":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="b
|
|
Run test suite:
tests/unit/components/settingsModal.test.jsx#L106
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Done"
Here are the accessible roles:
dialog:
Name "settings":
<div
aria-labelledby="settings-modal-title"
aria-modal="true"
class="relative flex flex-col overflow-hidden rounded-[26px] border border-white/12 text-white shadow-[0_24px_80px_rgba(0,0,0,0.62)]"
role="dialog"
style="z-index: 1; width: 62vw; min-width: 720px; max-width: 920px; height: auto; padding: 16px; background-color: rgba(28, 28, 28, 0.95); transform: translateY(8px) scale(0.985); transition: transform 200ms cubic-bezier(0.22, 1, 0.36, 1);"
/>
--------------------------------------------------
heading:
Name "settings":
<h2
class="text-[16px] font-medium"
id="settings-modal-title"
/>
--------------------------------------------------
checkbox:
Name "settingsHideAppWhenUnfocused":
<input
checked=""
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsKeepAppInTray":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsHideWindowOnLaunch":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsOpenAtLogin":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsHideDockIconWhenHidden":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsCopyingImageToClipboard":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsSavingImage":
<input
checked=""
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
Name "settingsSavingToFolder":
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
--------------------------------------------------
combobox:
Name "":
<select
class="w-full rounded-[8px] bg-white/5 px-3 py-2 text-[13px] text-white/90 outline-none border border-white/10"
/>
--------------------------------------------------
option:
Name "English":
<option
value="en"
/>
Name "简体中文":
<option
value="zh-Hans"
/>
Name "繁體中文":
<option
value="zh-Hant"
/>
Name "한국어":
<option
value="ko"
/>
Name "Français":
<option
value="fr"
/>
Name "हिन्दी":
<option
value="hi"
/>
Name "Español":
<option
value="es"
/>
--------------------------------------------------
button:
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsChange":
<button
class="rounded-[8px] px-2.5 py-1 text-[11px] bg-white/5 text-white/90 hover:bg-white/10"
type="button"
/>
Name "reset":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="button"
/>
Name "settingsResetAll":
<button
class="rounded-[8px] bg-white/5 px-2.5 py-1 text-[11px] text-white/90 hover:bg-white/10"
type="b
|
|
Run test suite:
tests/unit/components/settingsModal.test.jsx#L82
TestingLibraryElementError: Unable to find an element with the text: General. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
Ignored nodes: comments, script, style
<body
style="overflow: hidden;"
>
<div>
<div
class="fixed inset-0 flex items-center justify-center window-no-drag"
style="z-index: 300000; opacity: 0; transition: opacity 180ms ease;"
>
<div
aria-label="closeSettings"
class="absolute inset-0 bg-black/55"
/>
<div
aria-labelledby="settings-modal-title"
aria-modal="true"
class="relative flex flex-col overflow-hidden rounded-[26px] border border-white/12 text-white shadow-[0_24px_80px_rgba(0,0,0,0.62)]"
role="dialog"
style="z-index: 1; width: 62vw; min-width: 720px; max-width: 920px; height: auto; padding: 16px; background-color: rgba(28, 28, 28, 0.95); transform: translateY(8px) scale(0.985); transition: transform 200ms cubic-bezier(0.22, 1, 0.36, 1);"
>
<div
class="flex items-center border-b border-white/10 px-5 py-4"
>
<h2
class="text-[16px] font-medium"
id="settings-modal-title"
>
settings
</h2>
</div>
<div
class="px-6 py-6"
>
<div
class="grid grid-cols-2 gap-5 items-start"
>
<div
class="flex flex-col gap-2.5"
>
<div
class="px-1 text-[13px] font-inter font-medium text-white/50"
>
settingsGeneral
</div>
<section
class="rounded-[20px] bg-[#2C2C2C] p-[28px]"
>
<div
class="space-y-1"
>
<label
class="flex cursor-pointer items-center justify-between gap-3 rounded-[8px] px-3 py-2 text-[13px] hover:bg-white/5 transition-colors"
>
<span
class="text-white/90"
>
settingsHideAppWhenUnfocused
</span>
<input
checked=""
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
</label>
<label
class="flex cursor-pointer items-center justify-between gap-3 rounded-[8px] px-3 py-2 text-[13px] hover:bg-white/5 transition-colors"
>
<span
class="text-white/90"
>
settingsKeepAppInTray
</span>
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
</label>
<label
class="flex cursor-pointer items-center justify-between gap-3 rounded-[8px] px-3 py-2 text-[13px] hover:bg-white/5 transition-colors"
>
<span
class="text-white/90"
>
settingsHideWindowOnLaunch
</span>
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
</label>
<label
class="flex cursor-pointer items-center justify-between gap-3 rounded-[8px] px-3 py-2 text-[13px] hover:bg-white/5 transition-colors"
>
<span
class="text-white/90"
>
settingsOpenAtLogin
</span>
<input
class="h-4 w-4 accent-[#7c3aed]"
type="checkbox"
/>
</label>
<l
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
background
wait
wait-all
cancel
parallel
Loading