fix: Fix creating new scheduler item date#47
Merged
Rowan-Paul merged 1 commit intodevelopfrom May 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with creating new scheduler item dates by ensuring the correct date format is used.
- Updates tsconfig.server.json with additional compiler options for Node compatibility.
- Bumps dependency versions in package.json to align with new Strapi versions and updates the package manager setting.
- Modifies the Scheduler component to convert dates to an ISO string format.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.server.json | Added additional compiler options for module resolution and interoperability. |
| package.json | Updated version numbers and dependency versions to ensure compatibility. |
| admin/src/components/Scheduler/index.tsx | Changed date conversion from toDateString() to toISOString() to fix date creation. |
Comments suppressed due to low confidence (1)
admin/src/components/Scheduler/index.tsx:33
- [nitpick] The change to using toISOString() standardizes the date format; please verify that downstream components and API consumers expect dates in ISO format rather than human-readable strings.
const isoDate = value ? value.toISOString() : null;
MaikaiMa
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.