fix disabling swipes mid-swipe #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilterugur
added a commit
to ilterugur/react-native-deck-swiper-renewed
that referenced
this pull request
Nov 8, 2021
Owner
|
In order to merge this we need to properly QA the change. In order to do that please create a dummy app with the functionality so that the swiper can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while using a Slider inside the deck swiper. As I started to slide, I would also swipe. Solution was to pass up disable swipe event when slider started, but I found that this caused the swiper to freak out and stutter and eventually break. This fixes it