Skip to content

fix Card not re-render if state change on parent #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iyansr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Card not re-render if state change on parent #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Swiper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ class Swiper extends Component {
const { props, state } = this
const propsChanged = (
!isEqual(props.cards, nextProps.cards) ||
props.cardIndex !== nextProps.cardIndex
props.cardIndex !== nextProps.cardIndex ||
props.renderCard !== nextProps.renderCard
Copy link
Owner

@webraptor webraptor Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iyansr how does comparing the renderCard function help? I'm pretty sure it will not work or improve the swiper in any way, at least not without introducing a lot of other issues for other people.

)
const stateChanged = (
nextState.firstCardIndex !== state.firstCardIndex ||
Expand Down