Use new SocketTime replacing Instant #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boivie
force-pushed
the
feature-sockettime
branch
from
044621a to
7ef6f5b
Compare
boivie
changed the title
boivie
force-pushed
the
feature-sockettime
branch
3 times, most recently
from
c8d1e38 to
f301aff
Compare
Instant is a complicated type as it's opaque, and only useful with Duration. It cannot be created from a value, and it cannot be serialized and deserialized, and works poorly when interfacing C++. It typically represents the current time. This change introduces a type called SocketTime that represent a point in time relative to the socket's creation time. It's a strong type, wrapping an u64 representing nanoseconds since the socket was created. This simplifies interfacing with C++, and overall simplifies the API.
boivie
force-pushed
the
feature-sockettime
branch
from
f301aff to
3bd1ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instant is a complicated type as it's opaque, and only useful with Duration. It cannot be created from a value, and it cannot be serialized and deserialized, and works poorly when interfacing C++. It typically represents the current time.
This change introduces a type called SocketTime that represent a point in time relative to the socket's creation time. It's a strong type, wrapping a Duration, and with the definition that it's zero when the socket is created, the current time no longer has to be passed to the socket constructor.
This simplifies interfacing with C++, and overall simplifies the API.