Skip to content

feat: added functionalityt for remove_from_cart, add_to_cart, view_ca… - #20

Open
tinux-it wants to merge 1 commit into
websavers:mainfrom
Netbela-com:main
Open

feat: added functionalityt for remove_from_cart, add_to_cart, view_ca…#20
tinux-it wants to merge 1 commit into
websavers:mainfrom
Netbela-com:main

Conversation

@tinux-it

Copy link
Copy Markdown

HI,

With the help of AI, i've added quite some functionality:

  • Add a remove_from_cart datalayer
  • Add a view_cart datalayer
  • Ensure that the curreny is always trimmed
  • Ensure that domains adding and removal works properly for datasets
  • added information regarding available billingCycles (monthly / Yearly)
  • Ensure that the price is formatted properly into float instead of a string

Feel free to try it out and see if it fits your needs.

@jas8522 jas8522 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments about code quality.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with the function gtm_get_module_settings ?

You've created a var $settings set to null, then immediately after check to see if it's null?

static $settings = null;
    if (is_null($settings))

Then it also seems to be mixing up two vars:

  • $settings
  • $setting

Then further down in the code instances of Laravel Query Builder's ->value() are replaced with ->pluck() even though pluck is no longer the correct method of doing that: https://laracasts.com/discuss/channels/eloquent/pluck-is-replaced-with-value-in-51-update

I'm afraid this code needs some work before I can commit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants