feat: added functionalityt for remove_from_cart, add_to_cart, view_ca… - #20
Open
tinux-it wants to merge 1 commit into
Open
feat: added functionalityt for remove_from_cart, add_to_cart, view_ca…#20tinux-it wants to merge 1 commit into
tinux-it wants to merge 1 commit into
Conversation
…rt, billingCycles and proper domain pricing
jas8522
requested changes
Jan 14, 2026
jas8522
left a comment
Contributor
There was a problem hiding this comment.
See review comments about code quality.
Contributor
There was a problem hiding this comment.
What's going on with the function gtm_get_module_settings ?
You've created a var $settings set to null, then immediately after check to see if it's null?
static $settings = null;
if (is_null($settings))
Then it also seems to be mixing up two vars:
- $settings
- $setting
Then further down in the code instances of Laravel Query Builder's ->value() are replaced with ->pluck() even though pluck is no longer the correct method of doing that: https://laracasts.com/discuss/channels/eloquent/pluck-is-replaced-with-value-in-51-update
I'm afraid this code needs some work before I can commit it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI,
With the help of AI, i've added quite some functionality:
Feel free to try it out and see if it fits your needs.