Exclude rhumb from the build #24
Conversation
If we had more dependencies, we'd need to have a better story for this, but it'll do for now.
|
sigh... Of course the build fails because npm.. |
|
Heh, actuallly this is because in the makefile we set the path to the local node_modules/.bin folder. Node 5 ships with NPM 3, which dedupes and installs modules in an as-flat-as-possible manner, meaning somewhere deep in the dev dependencies there's something that depends on the touch module. This then understandably gets confused because we touch the node_modules dir after npm install, and that module doesn't really deal well with directories. (See: isaacs/node-touch/issues/8) So yeah – the build fails because NPM, but I guess it's also pretty stupid to prepend |
This fixes the broken build when npm 3 is used.
|
That's strange, the build still fails with the same error – but it works fine locally with Node 5 and npm 3. Investigating.. |
We may just want to look into Wercker instead, so we can have a deterministic environment for the builds.
|
Seems travis-ci/travis-ci#4862 covers what's going on, and offers a workaround. I'm going to implement the workaround for now, and then look into using wercker instead at some point down the line. |
mstade
changed the title
There was a problem hiding this comment.
Are you bumping the version by hand?
There was a problem hiding this comment.
No, using npm version. I'm going with the no-one-really-cares-about-semver-before-1.0 approach, so bumping minor for the breaking changes and patch for non-breaking. Once we hit 1.0.0 though we should take better care.
@grancalavera this oughta do it. When we merge this, we should also merge this: websdk/nap-examples#1.