Storage Disk #29
Open
Storage Disk #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websmurf
reviewed
Mar 10, 2025
| /** | ||
| * The Webhook secret | ||
| */ | ||
| 'exact_webhook_secret' => env('EXACT_WEBHOOK_SECRET', ''), |
Owner
There was a problem hiding this comment.
this config value isn't used in your code, so can you remove it?
| /** | ||
| * The web url | ||
| */ | ||
| 'exact_web_url' => env('EXACT_WEB_URL', ''), |
Owner
There was a problem hiding this comment.
this config value isn't used in your code, so can you remove it?
| /** | ||
| * The storage | ||
| */ | ||
| 'exact-api-storage' => env('EXACT_API_STORAGE', 'local'), |
Owner
There was a problem hiding this comment.
Perhaps using NULL as a default value is better here, in that way the Storage::disk method will be called with a null value, resulting in backward compatible behaviour (it will use the default configured disk)
In that way it will not break existing applications that do not use the local disk as their default filesystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
src/LaravelExactOnline.phpandsrc/config/laravel-exact-online.phpfiles to enhance configuration management and storage handling. The most important changes include the addition of new configuration options and modifications to storage handling methods.Enhancements to configuration management:
src/config/laravel-exact-online.php: Added new configuration options forexact_webhook_secret,exact_web_url, andexact-api-storage.Improvements to storage handling:
src/LaravelExactOnline.php: Modified theloadConfigmethod to use a configurable storage disk instead of the default storage.src/LaravelExactOnline.php: Updated thestoreConfigmethod to use a configurable storage disk for saving the configuration.