Add independent log parser fixture tests#34
Open
pengyuayn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds independent, hand-written log parser fixtures for JSON, plain-text, nginx-style access logs, and malformed/unsupported lines. The fixtures validate parser output without relying on samples generated by the parser itself.
Changes
tests/fixtures/log_aggregator/with representative JSON, text, nginx, and malformed log lines.tests/test_log_aggregator_fixtures.pycovering timestamp, level, service/format, nginx key fields, malformed input behavior, and CLI export compatibility.Validation
python3 -m unittest tests/test_log_aggregator_fixtures.pypasses: 5 tests OK.python3 build.pywas run. It completed module execution but exited non-zero in this local macOS environment because cargo/go/luac/ghc are not installed and frailbox C compilation fails locally. It attempted to creatediagnostic/build-bf2147ac.logd, but encryptly failed during logd creation, so no diagnostic artifact was produced on this machine.Notes
Fixture source/intent: the log lines are hand-written representatives of archived production-like formats, not generated by
tools/log_aggregator.py. They are intentionally small and focused on parser contract validation.