Always rebuild analytics cache after write operations#241
Merged
Conversation
When GetMessagesRawBatch returns nil for a message (typically a 404 because the message was deleted between listing and fetching), the error count was incremented but no message ID was logged. This made it impossible to diagnose which messages failed to sync. Add Warn-level logging with the message ID in both incremental and full sync paths so failed fetches are visible in logs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The serve command rebuilds the Parquet analytics cache after each sync, but the standalone CLI commands did not. This caused stale search results when syncs were triggered via launchd or manual CLI. Rather than always rebuilding (which couples sync and caching), add an opt-in --rebuild-cache flag that users can enable in their launchd config or scripts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When the flag is set, always run buildCache rather than gating on cacheNeedsBuild. The staleness check is still consulted to decide whether a full rebuild is needed, but the cache build itself runs unconditionally so users can recover from bad-but-undetected cache states. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When the user explicitly requests cache rebuild via --rebuild-cache, failures should cause a non-zero exit so automation can detect them. Previously these were silently downgraded to log warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Report cache failures independently rather than mixing them into the "account(s) failed to sync" message. Sync failures and cache failures are now distinct error paths with accurate messages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rebuildCacheAfterWrite(dbPath)helper that checks staleness, runs incremental or full rebuild as needed, and warns on failuresync,sync-full,import-emlx,import-imessage,import-gvoice,import-whatsapp,import-mbox,repair-encoding,delete-staged--rebuild-cacheflag from sync commands (redundant — cache always rebuilds)Cache rebuild failure is a warning, not a command error — the primary operation (sync/import) succeeded and data is safe in SQLite.
🤖 Generated with Claude Code