feat: expose CC and BCC recipients in message API#242
Open
danshapiro wants to merge 1 commit intowesm:mainfrom
Open
feat: expose CC and BCC recipients in message API#242danshapiro wants to merge 1 commit intowesm:mainfrom
danshapiro wants to merge 1 commit intowesm:mainfrom
Conversation
The message_recipients table already stores cc and bcc recipient types from Gmail sync (215K CC rows, 4.5K BCC rows), but the API only returned "to" recipients. This adds cc and bcc fields to MessageSummary and populates them via the existing batchGetRecipients and getRecipients helpers. Also refactors ListMessages to use batchPopulate (like SearchMessages already does) to avoid duplicating the batch-loading logic. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_recipientstable already storesccandbccrecipient types from Gmail sync (215K CC rows, 4.5K BCC rows in production), but the API only returnedtorecipientsccandbccfields toMessageSummary(omitted from JSON when empty)batchGetRecipients/getRecipientshelpers for both list and detail endpointsListMessagesto usebatchPopulate(likeSearchMessagesalready does) to avoid duplicating batch-loading logicTest plan
go test ./internal/store/... ./internal/api/...)/api/v1/messageslist response for messages with CC recipients/api/v1/messages/{id}detail response🤖 Generated with Claude Code