build(deps): bump vite from 7.0.4 to 7.1.7 in /app/vmui/packages/vmui

.github/workflows/build.yml

@@ -37,7 +37,7 @@ jobs:
 
       - name: Setup Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: stable
           cache: false

.github/workflows/check-licenses.yml

@@ -19,7 +19,7 @@ jobs:
 
       - name: Setup Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: stable
           cache: false

.github/workflows/codeql-analysis-go.yml

@@ -31,7 +31,7 @@ jobs:
 
       - name: Set up Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           cache: false
           go-version: stable

.github/workflows/main.yml

@@ -33,7 +33,7 @@ jobs:
 
       - name: Setup Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           cache: false
           go-version: stable
@@ -71,7 +71,7 @@ jobs:
 
       - name: Setup Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           cache: false
           go-version: stable
@@ -105,7 +105,7 @@ jobs:
 
       - name: Setup Go
         id: go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           cache: false
           go-version: stable

.github/workflows/vmui.yml

@@ -33,7 +33,7 @@ jobs:
         uses: actions/checkout@v5
 
       - name: Setup Node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v5
         with:
           node-version: '24.x'
 

app/vlinsert/elasticsearch/elasticsearch.go

@@ -187,7 +187,10 @@ func readBulkLine(lr *insertutil.LineReader, timeFields, msgFields []string, lmp
 		// Continue parsing next lines.
 		return true, nil
 	}
+
 	p := logstorage.GetJSONParser()
+	defer logstorage.PutJSONParser(p)
+
 	if err := p.ParseLogMessage(line); err != nil {
 		return false, fmt.Errorf("cannot parse json-encoded log entry: %w", err)
 	}
@@ -201,7 +204,6 @@ func readBulkLine(lr *insertutil.LineReader, timeFields, msgFields []string, lmp
 	}
 	logstorage.RenameField(p.Fields, msgFields, "_msg")
 	lmp.AddRow(ts, p.Fields, nil)
-	logstorage.PutJSONParser(p)
 
 	return true, nil
 }

app/vlinsert/opentelemetry/opentelemetry.go

@@ -50,7 +50,7 @@ func handleProtobuf(r *http.Request, w http.ResponseWriter) {
 
 	encoding := r.Header.Get("Content-Encoding")
 	err = protoparserutil.ReadUncompressedData(r.Body, encoding, maxRequestSize, func(data []byte) error {
-		lmp := cp.NewLogMessageProcessor("opentelelemtry_protobuf", false)
+		lmp := cp.NewLogMessageProcessor("opentelemetry_protobuf", false)
 		useDefaultStreamFields := len(cp.StreamFields) == 0
 		err := pushProtobufRequest(data, lmp, cp.MsgFields, useDefaultStreamFields)
 		lmp.MustClose()

app/vlselect/internalselect/internalselect.go

@@ -2,6 +2,7 @@ package internalselect
 
 import (
 	"context"
+	"flag"
 	"fmt"
 	"net/http"
 	"strconv"
@@ -21,10 +22,42 @@ import (
 	"github.com/VictoriaMetrics/VictoriaLogs/lib/logstorage"
 )
 
+var maxConcurrentRequests = flag.Int("internalselect.maxConcurrentRequests", 100, "The limit on the number of concurrent requests to /internal/select/* endpoints; "+
+	"other requests are put into the wait queue; see https://docs.victoriametrics.com/victorialogs/cluster/")
+
 // RequestHandler processes requests to /internal/select/*
 func RequestHandler(ctx context.Context, w http.ResponseWriter, r *http.Request) {
 	startTime := time.Now()
 
+	select {
+	case concurrencyLimitCh <- struct{}{}:
+		if d := time.Since(startTime); d > 100*time.Millisecond {
+			// Measure the wait duration for requests, which hit the concurrency limit and waited for more than 100 milliseconds to be executed.
+			concurrentRequestsWaitDuration.Update(d.Seconds())
+		}
+		requestHandler(ctx, w, r, startTime)
+		<-concurrencyLimitCh
+	case <-ctx.Done():
+		// Unconditionally measure the wait time until the the request is canceled by the client.
+		concurrentRequestsWaitDuration.UpdateDuration(startTime)
+	}
+}
+
+// Init initializes internalselect package.
+func Init() {
+	concurrencyLimitCh = make(chan struct{}, *maxConcurrentRequests)
+}
+
+// Stop stops vlselect
+func Stop() {
+	concurrencyLimitCh = nil
+}
+
+var concurrencyLimitCh chan struct{}
+
+var concurrentRequestsWaitDuration = metrics.NewSummary(`vl_concurrent_internalselect_requests_wait_duration`)
+
+func requestHandler(ctx context.Context, w http.ResponseWriter, r *http.Request, startTime time.Time) {
 	path := r.URL.Path
 	rh := requestHandlers[path]
 	if rh == nil {
@@ -277,14 +310,18 @@ type commonParams struct {
 	TenantIDs []logstorage.TenantID
 	Query     *logstorage.Query
 
+	// Whether to disable compression of the response sent to the vlselect.
 	DisableCompression bool
 
+	// Whether to allow partial response when some of vlstorage nodes are unavailable.
+	AllowPartialResponse bool
+
 	// qs contains execution statistics for the Query.
 	qs logstorage.QueryStats
 }
 
 func (cp *commonParams) NewQueryContext(ctx context.Context) *logstorage.QueryContext {
-	return logstorage.NewQueryContext(ctx, &cp.qs, cp.TenantIDs, cp.Query)
+	return logstorage.NewQueryContext(ctx, &cp.qs, cp.TenantIDs, cp.Query, cp.AllowPartialResponse)
 }
 
 func (cp *commonParams) UpdatePerQueryStatsMetrics() {
@@ -314,17 +351,23 @@ func getCommonParams(r *http.Request, expectedProtocolVersion string) (*commonPa
 		return nil, fmt.Errorf("cannot unmarshal query=%q: %w", qStr, err)
 	}
 
-	s := r.FormValue("disable_compression")
-	disableCompression, err := strconv.ParseBool(s)
-	if err != nil {
-		return nil, fmt.Errorf("cannot parse disable_compression=%q: %w", s, err)
+	disableCompression := false
+	if err := getBoolFromRequest(&disableCompression, r, "disable_compression"); err != nil {
+		return nil, err
+	}
+
+	allowPartialResponse := false
+	if err := getBoolFromRequest(&allowPartialResponse, r, "allow_partial_response"); err != nil {
+		return nil, err
 	}
 
 	cp := &commonParams{
 		TenantIDs: tenantIDs,
 		Query:     q,
 
 		DisableCompression: disableCompression,
+
+		AllowPartialResponse: allowPartialResponse,
 	}
 	return cp, nil
 }
@@ -369,3 +412,16 @@ func getInt64FromRequest(r *http.Request, argName string) (int64, error) {
 	}
 	return n, nil
 }
+
+func getBoolFromRequest(dst *bool, r *http.Request, argName string) error {
+	s := r.FormValue(argName)
+	if s == "" {
+		return nil
+	}
+	b, err := strconv.ParseBool(s)
+	if err != nil {
+		return fmt.Errorf("cannot parse %s=%q as bool: %w", argName, s, err)
+	}
+	*dst = b
+	return nil
+}

app/vlselect/logsql/logsql.go

@@ -17,6 +17,7 @@ import (
 
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/atomicutil"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
+	"github.com/VictoriaMetrics/VictoriaMetrics/lib/flagutil"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/httpserver"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/httputil"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
@@ -29,8 +30,12 @@ import (
 )
 
 var (
-	maxQueryTimeRange = flag.Duration("search.maxQueryTimeRange", 0, "The maximum time range, which can be set in the query sent to querying APIs. "+
+	maxQueryTimeRange = flagutil.NewExtendedDuration("search.maxQueryTimeRange", "0", "The maximum time range, which can be set in the query sent to querying APIs. "+
 		"Queries with bigger time ranges are rejected. See https://docs.victoriametrics.com/victorialogs/querying/#resource-usage-limits")
+
+	allowPartialResponseFlag = flag.Bool("search.allowPartialResponse", false, "Whether to allow returning partial responses when some of vlstorage nodes "+
+		"from the -storageNode list are unavaialbe for querying. This flag works only for cluster setup of VictoriaLogs. "+
+		"See https://docs.victoriametrics.com/victorialogs/querying/#partial-responses")
 )
 
 // ProcessFacetsRequest handles /select/logsql/facets request.
@@ -79,9 +84,19 @@ func ProcessFacetsRequest(ctx context.Context, w http.ResponseWriter, r *http.Re
 			logger.Panicf("BUG: expecting 3 columns; got %d columns", len(columns))
 		}
 
-		fieldNames := columns[0].Values
-		fieldValues := columns[1].Values
-		hits := columns[2].Values
+		// Fetch columns by name to avoid relying on column ordering at VictoriaLogs cluster.
+		// See https://github.com/VictoriaMetrics/VictoriaLogs/issues/648
+		cFieldName := db.GetColumnByName("field_name")
+		cFieldValue := db.GetColumnByName("field_value")
+		cHits := db.GetColumnByName("hits")
+		if cFieldName == nil || cFieldValue == nil || cHits == nil {
+			logger.Panicf("BUG: missing expected columns for facets response: field_name=%v, field_value=%v, hits=%v",
+				cFieldName != nil, cFieldValue != nil, cHits != nil)
+		}
+
+		fieldNames := cFieldName.Values
+		fieldValues := cFieldValue.Values
+		hits := cHits.Values
 
 		bb := blockResultPool.Get()
 		for i := range fieldNames {
@@ -1093,6 +1108,10 @@ type commonArgs struct {
 	// tenantIDs is the list of tenantIDs to query.
 	tenantIDs []logstorage.TenantID
 
+	// Whether to allow partial response when some of vlstorage nodes are unavailable for querying.
+	// This option makes sense only for cluster setup when vlselect queries vlstorage nodes.
+	allowPartialResponse bool
+
 	// minTimestamp and maxTimestamp is the time range specified in the original query,
 	// without taking into account extra_filters and (start, end) query args.
 	minTimestamp int64
@@ -1103,7 +1122,7 @@ type commonArgs struct {
 }
 
 func (ca *commonArgs) newQueryContext(ctx context.Context) *logstorage.QueryContext {
-	return logstorage.NewQueryContext(ctx, &ca.qs, ca.tenantIDs, ca.q)
+	return logstorage.NewQueryContext(ctx, &ca.qs, ca.tenantIDs, ca.q, ca.allowPartialResponse)
 }
 
 func (ca *commonArgs) updatePerQueryStatsMetrics() {
@@ -1200,22 +1219,29 @@ func parseCommonArgs(r *http.Request) (*commonArgs, error) {
 		}
 	}
 
-	if *maxQueryTimeRange > 0 {
+	if maxRange := maxQueryTimeRange.Duration(); maxRange > 0 {
 		start, end := q.GetFilterTimeRange()
 		if end > start {
 			queryTimeRange := end - start
-			if queryTimeRange < 0 || queryTimeRange > maxQueryTimeRange.Nanoseconds() {
+			if queryTimeRange < 0 || queryTimeRange > maxRange.Nanoseconds() {
 				return nil, fmt.Errorf("too big time range selected: [%s, %s]; it cannot exceed -search.maxQueryTimeRange=%s; "+
 					"see https://docs.victoriametrics.com/victorialogs/querying/#resource-usage-limits",
-					timestampToString(start), timestampToString(end), *maxQueryTimeRange)
+					timestampToString(start), timestampToString(end), maxRange)
 			}
 		}
 	}
 
+	allowPartialResponse := *allowPartialResponseFlag
+	if err := getBoolFromRequest(&allowPartialResponse, r, "allow_partial_response"); err != nil {
+		return nil, err
+	}
+
 	ca := &commonArgs{
 		q:         q,
 		tenantIDs: tenantIDs,
 
+		allowPartialResponse: allowPartialResponse,
+
 		minTimestamp: minTimestamp,
 		maxTimestamp: maxTimestamp,
 	}
@@ -1363,6 +1389,19 @@ func getPositiveInt(r *http.Request, argName string) (int, error) {
 	return n, nil
 }
 
+func getBoolFromRequest(dst *bool, r *http.Request, argName string) error {
+	s := r.FormValue(argName)
+	if s == "" {
+		return nil
+	}
+	b, err := strconv.ParseBool(s)
+	if err != nil {
+		return fmt.Errorf("cannot parse %s=%q as bool: %w", argName, s, err)
+	}
+	*dst = b
+	return nil
+}
+
 func writeRequestDuration(h http.Header, startTime time.Time) {
 	h.Set("Access-Control-Expose-Headers", "VL-Request-Duration-Seconds")
 	h.Set("VL-Request-Duration-Seconds", fmt.Sprintf("%.3f", time.Since(startTime).Seconds()))

app/vlselect/main.go

@@ -48,10 +48,15 @@ func getDefaultMaxConcurrentRequests() int {
 // Init initializes vlselect
 func Init() {
 	concurrencyLimitCh = make(chan struct{}, *maxConcurrentRequests)
+
+	internalselect.Init()
 }
 
 // Stop stops vlselect
 func Stop() {
+	internalselect.Stop()
+
+	concurrencyLimitCh = nil
 }
 
 var concurrencyLimitCh chan struct{}