Fixing artifact upload clashes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses artifact upload clashes in the CI workflow by refining the naming and processing of uploaded artifacts.
- Renames the artifact upload steps for wheels and sdist builds.
- Introduces a new step to prepare distribution files by copying wheel and sdist artifacts into a dedicated directory.
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:22
- [nitpick] The dynamic artifact name 'wheels-${{ matrix.os }}' is clear, but consider verifying that it remains unique as new OS variants are added to avoid potential future conflicts.
name: wheels-${{ matrix.os }}
.github/workflows/build.yml:46
- The wildcard pattern 'dist/wheels-/.whl' may be too broad and could inadvertently copy unintended files. Consider refining the pattern to target only the intended wheel artifacts.
cp dist/wheels-*/*.whl final_dist/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.