Added %D for 24-hour time and buffering to let Print() based logging …#2
Open
Dekker3D wants to merge 1 commit intowildstarnasa:masterfrom
Open
Added %D for 24-hour time and buffering to let Print() based logging …#2Dekker3D wants to merge 1 commit intowildstarnasa:masterfrom
Dekker3D wants to merge 1 commit intowildstarnasa:masterfrom
Conversation
…work before everything is loaded properly.
|
Is there a way to toggle the setting on whether to use buffering or not? |
Author
|
It's not supposed to be used once you clear the buffer, the buffer only exists to bypass the problem with Print() swallowing messages when the chat isn't ready yet. I could probably make the GeminiConsole appender ignore the buffer if it can find GeminiConsole though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…work before everything is loaded properly.
This seemed necessary to me, to make this an improvement to my own logging code. Figured I'd make a pull request in case anyone is still watching this.