Skip to content

Don't merge! added comp art comments. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennis-chen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't merge! added comp art comments. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion computational_art/recursive_art.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def build_random_function(min_depth, max_depth):

depth = random.randint(min_depth, max_depth)
function = make_function(depth)
#clever, I guess this technically works! The wording of the assignment was somewhat ambiguous so I'm not going to take points of for this, but the intention was for every 'x' or 'y' in this function to be randomly nested at a depth somewhere between min_depth and max_depth.
#currently, in your code, every 'x' or 'y' is nested at the same depth. Can you think of how you would change your code to have that depth be random, between min_depth and max_depth?
return function

def make_function(depth):
Expand All @@ -30,6 +32,7 @@ def make_function(depth):
else:
modifiers = ["prod", "avg", "cos_pi", "sin_pi", "tan_pi", "asin_pi"]
rand_modifier = random.choice(modifiers)
# try to avoid using in when comparing strings for equality, as it obscures what you're doing and the intention is not clear. Instead, just do if rand_modifier == "prod", which is more readable.
if "prod" in rand_modifier:
return ["prod", make_function(depth-1), make_function(depth-1)]
if "avg" in rand_modifier:
Expand Down Expand Up @@ -68,6 +71,7 @@ def evaluate_random_function(function, x, y):
return math.tan(math.pi * evaluate_random_function(function[1], x, y))
elif "asin_pi" in function[0]:
return math.asin(math.pi * evaluate_random_function(function[1], x, y))
#nice and compact, cool! :)

def remap_interval(val, input_interval_start, input_interval_end, output_interval_start, output_interval_end):
""" Given an input value in the interval [input_interval_start,
Expand Down Expand Up @@ -95,7 +99,7 @@ def remap_interval(val, input_interval_start, input_interval_end, output_interva
input_range = input_interval_end - float(input_interval_start) #turns input_interval_start into a float to prevent integer division problems
output_range = output_interval_end - output_interval_start
return (((val - input_interval_start) / input_range) * output_range) + output_interval_start

#nice, good job choosing variable names too!

def color_map(val):
""" Maps input value between -1 and 1 to an integer 0-255, suitable for
Expand Down