Use emplace_back() more.

wilx · Dec 8, 2024 · f16c0a0 · f16c0a0
1 parent c15260a
commit f16c0a0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/src/env.cxx b/src/env.cxx
@@ -384,7 +384,7 @@ split_into_components(Container & components, tstring const & path,
     while (it != end)
     {
         tstring::const_iterator sep = std::find_if (it, end, is_sep);
-        components.push_back (tstring (it, sep));
+        components.emplace_back (it, sep);
         it = sep;
         if (it != end)
             ++it;

diff --git a/src/ndc.cxx b/src/ndc.cxx
@@ -249,11 +249,11 @@ NDC::push_worker (StringType const & message)
 {
     DiagnosticContextStack* ptr = getPtr();
     if (ptr->empty())
-        ptr->push_back( DiagnosticContext(message, nullptr) );
+        ptr->emplace_back (message, nullptr);
     else
     {
         DiagnosticContext const & dc = ptr->back();
-        ptr->push_back( DiagnosticContext(message, &dc) );
+        ptr->emplace_back (message, &dc);
     }
 }
 

diff --git a/src/patternlayout.cxx b/src/patternlayout.cxx
@@ -767,9 +767,8 @@ PatternParser::parse()
                     break;
                 default:
                     if(! currentLiteral.empty ()) {
-                        list.push_back
-                            (std::unique_ptr<PatternConverter>(
-                                new LiteralPatternConverter(currentLiteral)));
+                        list.emplace_back (
+                            new LiteralPatternConverter(currentLiteral));
                         //getLogLog().debug("Parsed LITERAL converter: \""
                         //                  +currentLiteral+"\".");
                     }
@@ -850,9 +849,7 @@ PatternParser::parse()
     } // end while
 
     if(! currentLiteral.empty ()) {
-        list.push_back(
-            std::unique_ptr<PatternConverter>(
-                new LiteralPatternConverter(currentLiteral)));
+        list.emplace_back(new LiteralPatternConverter(currentLiteral));
       //getLogLog().debug("Parsed LITERAL converter: \""+currentLiteral+"\".");
     }
 
@@ -1022,7 +1019,7 @@ PatternParser::finalizeConverter(tchar c)
             pc = new LiteralPatternConverter(currentLiteral);
     }
 
-    list.push_back(std::unique_ptr<PatternConverter>(pc));
+    list.emplace_back(pc);
     currentLiteral.resize(0);
     state = LITERAL_STATE;
     formattingInfo.reset();
@@ -1098,10 +1095,9 @@ PatternLayout::init(const tstring& pattern_, unsigned ndcMaxDepth)
     {
         helpers::getLogLog().warn(
             LOG4CPLUS_TEXT("PatternLayout pattern is empty.  Using default..."));
-        parsedPattern.push_back (
-            std::unique_ptr<pattern::PatternConverter>(
+        parsedPattern.emplace_back (
                 new pattern::BasicPatternConverter(pattern::FormattingInfo(),
-                    pattern::BasicPatternConverter::MESSAGE_CONVERTER)));
+                    pattern::BasicPatternConverter::MESSAGE_CONVERTER));
     }
 }