feat: remove pip fallback option for python and ansible

[pyranota]

pip was deprecated since 1.425.0 (2024-11-15)

---

Important

Remove deprecated pip fallback options for Python and Ansible, cleaning up related code and configurations.

• Behavior:
  • Remove pip fallback logic in uv_pip_compile() and spawn_uv_install() in python_executor.rs.
  • Remove pip related constants in worker.rs and worker_lockfiles.rs.
  • Delete download.py.pip.config.proto and download_deps.py.pip.sh.
• Configuration:
  • Remove LOCK_CACHE_DIR and PIP_CACHE_DIR from main.rs and worker.rs.
  • Remove no_uv related flags from PythonAnnotations in worker.rs.
• Misc:
  • Update handle_ansible_python_deps() in ansible_executor.rs to remove pip fallback.
  • Remove USE_PIP_COMPILE and USE_PIP_INSTALL from python_executor.rs and worker_lockfiles.rs.

^{This description was created by for d4d0d19. It will automatically update as commits are pushed.}

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	d4d0d19
Status:	✅  Deploy successful!
Preview URL:	https://3837f364.windmill.pages.dev
Branch Preview URL:	https://py-remove-pip.windmill.pages.dev

View logs

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d4d0d19 in 1 minute and 28 seconds

More details

• Looked at 912 lines of code in 10 files
• Skipped 0 files when reviewing.
• Skipped posting 8 drafted comments based on config settings.

1. backend/windmill-worker/src/worker_lockfiles.rs:159

• Draft comment:
  In 'try_normalize', calling to_str() later (e.g. in parse_bun_relative_imports) may panic on non-UTF8 paths. Consider handling non-UTF8 filenames more gracefully.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. backend/windmill-worker/src/worker_lockfiles.rs:186

• Draft comment:
  In 'parse_bun_relative_imports', if 'try_normalize' returns None, an error is logged but no fallback is provided. Consider returning an informative error or handling the None case.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. backend/windmill-worker/src/worker_lockfiles.rs:113

• Draft comment:
  Review the SQL in 'clear_dependency_map_for_item'; using '($4::text IS NULL OR importer_node_id = $4::text)' may benefit from clearer parameter handling or comments explaining the logic.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

4. backend/windmill-worker/src/worker_lockfiles.rs:1155

• Draft comment:
  The 'lock_modules' function is heavily recursive and complex. Consider refactoring or adding more inline documentation to improve maintainability and reduce cognitive load.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. backend/windmill-worker/src/worker_lockfiles.rs:1205

• Draft comment:
  In 'reduce_flow', the pattern matching on FlowModuleValue uses an 'unreachable!' branch. Consider adding explicit error messages to handle unexpected cases gracefully.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. backend/windmill-worker/src/worker_lockfiles.rs:295

• Draft comment:
  After updating the 'script' table in 'handle_dependency_job', cache invalidation is done using 'cache::script::invalidate'. Consider checking and logging errors from cache invalidation to ensure consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. backend/windmill-worker/src/python_executor.rs:428

• Draft comment:
  In the 'uv_pip_compile' function the pip fallback branch is now removed so that dependency resolution always uses the 'uv' tool. Make sure tests & documentation are updated to reflect that pip (deprecated since 1.425.0) is no longer used.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. backend/windmill-worker/src/ansible_executor.rs:77

• Draft comment:
  The Ansible dependencies handling now calls 'uv_pip_compile' directly, removing the pip fallback option. Verify that the change aligns with expected behavior for resolving Python dependencies in Ansible jobs.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_DPj9g5ul1j7prM19

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.