Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isomorphic wasi (again) and patched wasi-js #1584

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Feb 19, 2023

This PR reintroduces #1571 with 3 additional changes to avoid the last regression:

  • patch-package is used to mess with wasi-js, to remove the preinstall script from their package.json. The patching is performed during packaging, where it's actually effective (for downstream consumers).
  • wasi-js is included as a bundled dep for winglang to ensure that the patched package.json is appropriately included in time and not just replaced when wing is installed. Normally this isn't needed with patch package, but due to the particular mutation I'm not sure this is avoidable
  • Added checks to hangar to ensure we avoid introducing script hooks. I verified that these tests pass with the latest version of the repo but fail the version noted in the regression.

The changes from the original PR are untouched.

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner February 19, 2023 22:35
apps/wing/patches/wasi-js+1.7.3.patch Show resolved Hide resolved
apps/wing/package.json Show resolved Hide resolved
tools/hangar/src/package.setup.ts Show resolved Hide resolved
tools/hangar/src/package.setup.ts Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e8e8860 into main Feb 20, 2023
@mergify mergify bot deleted the mark/hate-install-scripts branch February 20, 2023 12:02
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.5.57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants