Also build static nghttp2 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration option is available as of nghttp2 1.9.0, so there shouldmn't be issues if we would need to rebuild on old version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per se, this doesn't change much, unless we also build cURL against a static nghttp2. To not require to patch cURL when doing this, I've sticked with the default name nghttp2_static.lib (our naming convention would call that libnghtt2_a.lib, but the import library already does not conform to our naming conventions; and these might be something we want to consider to change anyway).
PS:
A test build is available.
Note that there is the branch https://github.com/winlibs/nghttp2/tree/nghttp2-1.20.0-with-static where apparently this had been done many ago, but apparently that has never been used. Don't know why.