Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update junit-jupiter.md. to reflect v3 method signature #326

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

rahultumpala
Copy link
Contributor

Method Signature for ResponseTemplateTransformer has changed in v3.
I've made changes in the document to reflect the same.

The following snippet is the actual constructor method in v3.10.0

public ResponseTemplateTransformer(TemplateEngine templateEngine, boolean global, FileSource files, List<TemplateModelDataProviderExtension> templateModelDataProviders) {
        this.templateEngine = templateEngine;
        this.global = global;
        this.files = files;
        this.templateModelDataProviders = templateModelDataProviders;
    }

Method Signature for ResponseTemplateTransformer has changed in v3. Made changes in docs to reflect the same.
@leeturner
Copy link
Contributor

Many thanks for your contribution. We do have another example of the use of this constructor in the response templating page. It looks something like this:

new ResponseTemplateTransformer(
              getTemplateEngine(),
              options.getResponseTemplatingGlobal(),
              getFiles(),
              templateModelProviders
            )

Could we keep it consistent and use the same parameters to the contructor in your update. Once that is updated, I will merge the change.

@rahultumpala
Copy link
Contributor Author

Yes, I will make the change.

@rahultumpala
Copy link
Contributor Author

@leeturner although it's a minor change I got occupied with work and couldn't get onto this early. I modified the document to reflect v3 definition and be consistent with Response Templating page. Please merge when you're free. Thanks.

@leeturner leeturner merged commit a420899 into wiremock:main Feb 4, 2025
1 check failed
@leeturner
Copy link
Contributor

Awesome, thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants