Skip to content

Conversation

carla-at-wiris
Copy link
Contributor

Description

CKEditor5 message:

CKEditor5 uses a null-prototype object when the editor configuration is modified using the editor.config.define() function, in order to prevent prototype pollution vulnerabilities.

https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-utils/src/config.ts#L198

MathType integration uses hasOwnProperty on the language object from the config, which causes an error when that property is defined using editor.config.define(), as the resulting object has a null prototype and does not include the hasOwnProperty method.

We need this change to prevent editor crashes when the language configuration is modified in this way.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project ( Run yarn lint to check)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes

How should be tested?

  • Uncomment the language lines of code in the CKEditor 5 demo to enable the specified language.
  • Build and start the application with nx build ckeditor5 and nx start html-ckeditor5 and validate the changes are made properly with no errors.

@carla-at-wiris carla-at-wiris self-assigned this Sep 8, 2025
@carla-at-wiris carla-at-wiris added the type:bug Something isn't working label Sep 8, 2025
@carla-at-wiris carla-at-wiris added the package:ckeditor5 Issues involving the plugin for CKEditor 5 label Sep 8, 2025
Copy link
Contributor

@usantos-at-wiris usantos-at-wiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ckeditor5 Issues involving the plugin for CKEditor 5 type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants