feat: redirect trailing slashes on on-demand rendered pages #12994

ascorbic · 2025-01-16T13:19:44Z

Changes

When the trailingSlash option is set to always or never, on-demand rendered pages will now redirect to the correct URL when the trailing slash is incorrect. This was previously the case for static pages, but now works for on-demand pages as well. There are some exceptions:

when the request matches a static path or file, it is not redirected
when trailingSlash is ignore then it is not redirected
when the request looks like it is for a file, it is not redirected, even if there is no matching file. e.g. a request for a nonexistent /favicon.ico will not redirect to /favicon.ico/
requests for paths starting with /_ with not redirect, because these are usually special internal paths

In dev we don't redirect so it's more obvious that a link is incorrect. Instead I have updated the 404 page to give a bit more information if there's a trailing slash mismatch, and suggest goign to the version with the correct slash:

Fixes #12532
Fixes #12833
Fixes #11575

Testing

Added a big test suite. Refer to it for more examples.

Docs

This will need docs

changeset-bot · 2025-01-16T13:19:51Z

🦋 Changeset detected

Latest commit: 0fdb109

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

codspeed-hq · 2025-01-16T13:32:47Z

CodSpeed Performance Report

Merging #12994 will not alter performance

_{Comparing trailing-magic (0fdb109) with main (e36837f)}

Summary

✅ 6 untouched benchmarks

packages/astro/src/core/app/index.ts

packages/internal-helpers/src/path.ts

packages/astro/src/core/app/index.ts

ascorbic · 2025-01-16T14:48:53Z

I wonder if this is a significant enough change to be behind an experimental flag.

ematipico · 2025-01-16T15:08:16Z

I wonder if this is a significant enough change to be behind an experimental flag.

This features seems to be mostly a change for adapters. In this case, you might want to add a new Astro feature:

astro/packages/astro/src/types/public/integrations.ts

Lines 100 to 130 in df90e6d

    
           export type AstroAdapterFeatureMap = { 
        
           	/** 
        
           	 * The adapter is able serve static pages 
        
           	 */ 
        
           	staticOutput?: AdapterSupport; 
        
           	/** 
        
           	 * The adapter is able to serve pages that are static or rendered via server 
        
           	 */ 
        
           	hybridOutput?: AdapterSupport; 
        
           	/** 
        
           	 * The adapter is able to serve SSR pages 
        
           	 */ 
        
           	serverOutput?: AdapterSupport; 
        
           	/** 
        
           	 * The adapter is able to support i18n domains 
        
           	 */ 
        
           	i18nDomains?: AdapterSupport; 
        
           	/** 
        
           	 * The adapter is able to support `getSecret` exported from `astro:env/server` 
        
           	 */ 
        
           	envGetSecret?: AdapterSupport; 
        
           	/** 
        
           	 * The adapter supports image transformation using the built-in Sharp image service 
        
           	 */ 
        
           	sharpImageService?: AdapterSupport; 
        
           };

Like this, adapters can opt-in and "break" things as much as they want, using their own versioning. What do you think?

ascorbic · 2025-01-16T15:11:01Z

I don't think so. This will work without any change on the adapter's part.

bluwy

This makes sense to me 👍 I don't think this could break things so probably don't need an experimental option

packages/astro/src/vite-plugin-astro-server/base.ts

ematipico · 2025-01-16T16:20:17Z

I don't think so. This will work without any change on the adapter's part.

That I know. I was suggesting an experimental path without necessarily having one in core, since this is a change that affects only on-demand pages with an adapter, and I would prefer this way because we don't know if users have already fixed this on their end.

matthewp · 2025-01-17T15:16:49Z

@ematipico why do you think this is breaking?

ascorbic · 2025-01-21T12:34:34Z

!preview trailing-slash-redirect

github-actions · 2025-01-21T12:36:15Z

Snapshots have been released for the following packages:

astro@experimental--trailing-slash-redirect

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--trailing-slash-redirect tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/web-vitals
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/studio
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-trailing-slash-redirect-20250121123511) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.2.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.11 is already published on npm
🦋  warn create-astro is not being published because version 4.11.0 is already published on npm
🦋  warn @astrojs/db is not being published because version 0.14.5 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.1 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.12.6 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 4.0.6 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.1.3 is already published on npm
🦋  warn @astrojs/preact is not being published because version 4.0.2 is already published on npm
🦋  warn @astrojs/react is not being published because version 4.1.5 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.2.1 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 5.0.3 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 7.0.3 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.4 is already published on npm
🦋  warn @astrojs/vue is not being published because version 5.0.5 is already published on npm
🦋  warn @astrojs/web-vitals is not being published because version 3.0.1 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.4.2 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 6.0.2 is already published on npm
🦋  warn @astrojs/studio is not being published because version 0.1.3 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.2.0 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.6.0 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.4.3 is already published on npm
🦋  info Publishing "astro" at "0.0.0-trailing-slash-redirect-20250121123511"
🦋  success packages published successfully:
🦋  [email protected]
🦋  Creating git tag...
🦋  New tag:  [email protected]

Build Log


> [email protected] build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/studio, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @astrojs/web-vitals, @benchmark/adapter, @benchmark/timer, astro, create-astro
• Running build in 29 packages
• Remote caching enabled
::group::@astrojs/telemetry:build
cache miss, executing d876d471dc4084c3

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/internal-helpers:build
cache miss, executing a2645d5c274fb4f7

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/internal-helpers
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::create-astro:build
cache miss, executing a513ef99a7061599

> [email protected] build /home/runner/work/astro/astro/packages/create-astro
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::@astrojs/upgrade:build
cache miss, executing d633ad364f73ba09

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/upgrade
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::@astrojs/prism:build
cache miss, executing 03f2919d025425f4

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-prism
> astro-scripts build "src/**/*.ts" && tsc -p ./tsconfig.json

::endgroup::
::group::@astrojs/markdown-remark:build
cache miss, executing 765afdc94755514e

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/markdown/remark
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::astro:build
cache miss, executing 317f0e9d79a67fe0

> [email protected] build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" --copy-wasm && tsc


> [email protected] prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"

::endgroup::
::group::@astrojs/studio:build
cache miss, executing 3777e5fa0a5bcbe8

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/studio
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing ccd4db1e1aa94a59

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 4efd35f98a9c20d4

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing eb6045f12825aae5

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/adapter:build
cache miss, executing 3c7b39c696d7dc86

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/adapter
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 7441636da8213514

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing 94fda5aa6d00ecf1

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 9f42babf21ae4520

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing bd1b260a8dbb0b18

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing 3bc5a795432ddb38

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 72027d5354b9c330

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing b9667b3402a7facb

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing b6b03356271c58d7

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing e7919ab24e15764e

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing 63df8cdba110cc70

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing d2c12e381ec2fe94

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/db:build
cache miss, executing e9382d391d1c0ee9

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc && pnpm types:virtual


> @astrojs/[email protected] types:virtual /home/runner/work/astro/astro/packages/db
> tsc -p ./tsconfig.virtual.json

::endgroup::
::group::@astrojs/web-vitals:build
cache miss, executing 9c9e132a2421953e

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/web-vitals
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    25 successful, 25 total
Cached:    0 cached, 25 total
  Time:    46.75s

sarah11918 · 2025-01-27T15:44:08Z

For docs, would just suggest taking a quick peek to make sure nothing here affects what we say in these places:

sarah11918

Just noting that when I look at this entry as a whole, I think we might be at the point where a restructuring is needed:

the first line mentions that this specifically is to configure how the dev server works, but there is also talk about "in production" below that's not particularly separated out/scannable for someone to find their use case
we clearly define the 3 options, but then in normal paragraph text give more specifics about some of the options. This might mean that we need to separate each of the 3 options and give them all their own content
there is a difference in how prerendered vs on demand works that's not separated out/scannable for someone to find their use case

Instead of adding on more notes/caveats, can we think of a better way to organize all this so people will be better easier to find the information they need quickly? Any thoughts on this?

packages/astro/src/template/4xx.ts

ascorbic · 2025-01-27T16:14:02Z

@sarah11918 I totally missed that this said it was just about dev server. That's already incorrect: it's used in production too.

ascorbic · 2025-01-27T17:47:36Z

@sarah11918 how about now

packages/astro/src/types/public/config.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

.changeset/many-fans-battle.md

.changeset/blue-spies-shave.md

packages/astro/src/types/public/config.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

ascorbic · 2025-01-28T15:34:12Z

!preview trailing-slash-redirect

github-actions · 2025-01-28T15:36:45Z

Snapshots have been released for the following packages:

@astrojs/internal-helpers@experimental--trailing-slash-redirect
astro@experimental--trailing-slash-redirect
@astrojs/markdoc@experimental--trailing-slash-redirect

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--trailing-slash-redirect tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/web-vitals
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/studio
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-trailing-slash-redirect-20250128153540) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.2.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.11 is already published on npm
🦋  warn create-astro is not being published because version 4.11.0 is already published on npm
🦋  warn @astrojs/db is not being published because version 0.14.5 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.1 is already published on npm
🦋  info @astrojs/markdoc is being published because our local version (0.0.0-trailing-slash-redirect-20250128153540) has not been published on npm
🦋  warn @astrojs/mdx is not being published because version 4.0.6 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.1.3 is already published on npm
🦋  warn @astrojs/preact is not being published because version 4.0.2 is already published on npm
🦋  warn @astrojs/react is not being published because version 4.1.5 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.2.1 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 5.0.3 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 7.0.3 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.4 is already published on npm
🦋  warn @astrojs/vue is not being published because version 5.0.5 is already published on npm
🦋  warn @astrojs/web-vitals is not being published because version 3.0.1 is already published on npm
🦋  info @astrojs/internal-helpers is being published because our local version (0.0.0-trailing-slash-redirect-20250128153540) has not been published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 6.0.2 is already published on npm
🦋  warn @astrojs/studio is not being published because version 0.1.3 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.2.0 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.6.0 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.4.3 is already published on npm
🦋  info Publishing "astro" at "0.0.0-trailing-slash-redirect-20250128153540"
🦋  info Publishing "@astrojs/markdoc" at "0.0.0-trailing-slash-redirect-20250128153540"
🦋  info Publishing "@astrojs/internal-helpers" at "0.0.0-trailing-slash-redirect-20250128153540"
🦋  success packages published successfully:
🦋  [email protected]
🦋  @astrojs/[email protected]
🦋  @astrojs/[email protected]
🦋  Creating git tags...
🦋  New tag:  [email protected]
🦋  New tag:  @astrojs/[email protected]
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/studio, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @astrojs/web-vitals, @benchmark/adapter, @benchmark/timer, astro, create-astro
• Running build in 29 packages
• Remote caching enabled
::group::@astrojs/internal-helpers:build
cache miss, executing 39da8f0138e8ae76

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/internal-helpers
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/prism:build
cache miss, executing cc629f14f2fa910e

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-prism
> astro-scripts build "src/**/*.ts" && tsc -p ./tsconfig.json

::endgroup::
::group::@astrojs/upgrade:build
cache miss, executing de87421b1e6ef02e

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/upgrade
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::create-astro:build
cache miss, executing 15b1f0a052dfdcfc

> [email protected] build /home/runner/work/astro/astro/packages/create-astro
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::@astrojs/telemetry:build
cache miss, executing f2094d55bca7fb7a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdown-remark:build
cache miss, executing c84ccf19c5002504

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/markdown/remark
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::astro:build
cache miss, executing a14abc9da70355fc

> [email protected] build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" --copy-wasm && tsc


> [email protected] prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"

::endgroup::
::group::@astrojs/studio:build
cache miss, executing cc5eca7cb98b8277

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/studio
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 40ac9aeff041a697

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@benchmark/adapter:build
cache miss, executing cc0b5a926b40b83a

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/adapter
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing e94370c66f9d57cb

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing da4c3ce0e0a19c35

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing 17281109ddff357f

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 1840440d4b720ac2

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing bd30005faaf3717b

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 18741b659b76a9e8

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing b2263f19b8c7760a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 5269901c433981b9

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing 8339be64650b3bce

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 60312719870a3d10

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 0384c57adea08fb0

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing 05efb1a085151a93

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing d4d3e175da50b90a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/db:build
cache miss, executing 9f0e64bab0307921

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc && pnpm types:virtual


> @astrojs/[email protected] types:virtual /home/runner/work/astro/astro/packages/db
> tsc -p ./tsconfig.virtual.json

::endgroup::
::group::@astrojs/web-vitals:build
cache miss, executing a39cde86c3a5ef7f

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/web-vitals
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    25 successful, 25 total
Cached:    0 cached, 25 total
  Time:    46.509s

sarah11918

Approving for docs!

feat: redirect trailing slashes on on-demand rendered pages

e95c8cf

github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Jan 16, 2025

github-actions bot requested changes Jan 16, 2025

View reviewed changes

Merge branch 'main' into trailing-magic

78d4aff

ematipico reviewed Jan 16, 2025

View reviewed changes

ascorbic added 2 commits January 16, 2025 14:44

Changes from review

d9a957f

Update test

1f1f07d

Changes from tests

4fbf0f1

bluwy approved these changes Jan 16, 2025

View reviewed changes

packages/astro/src/vite-plugin-astro-server/base.ts Outdated Show resolved Hide resolved

ascorbic added 2 commits January 16, 2025 15:48

fix: give a more helpful 404 page for trailing slash mismatch

2c1c2c9

Merge branch 'slash-404-hint' into trailing-magic

f8e74c1

ascorbic added 3 commits January 16, 2025 16:37

Refactor into separate middleware

20da681

Remove log

a39de6a

Fix test

25a0847

ascorbic mentioned this pull request Jan 21, 2025

build.format / trailingSlash / Astro.url / Astro.props.url interactions all seem bolloxed #12833

Closed

1 task

ematipico added this to the 5.2.0 milestone Jan 24, 2025

Add config docs

ffff9e9

github-actions bot added the docs pr label Jan 27, 2025

sarah11918 reviewed Jan 27, 2025

View reviewed changes

packages/astro/src/template/4xx.ts Outdated Show resolved Hide resolved

Change wording

476a95d

ascorbic force-pushed the trailing-magic branch from 5902224 to 476a95d Compare January 27, 2025 17:39

Update template

57feb05

sarah11918 reviewed Jan 27, 2025

View reviewed changes

packages/astro/src/types/public/config.ts Outdated Show resolved Hide resolved

sarah11918 reviewed Jan 27, 2025

View reviewed changes

packages/astro/src/types/public/config.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

aaca1ab

Co-authored-by: Sarah Rainsberger <[email protected]>

ematipico approved these changes Jan 28, 2025

View reviewed changes

sarah11918 reviewed Jan 28, 2025

View reviewed changes

.changeset/many-fans-battle.md Outdated Show resolved Hide resolved

sarah11918 reviewed Jan 28, 2025

View reviewed changes

.changeset/blue-spies-shave.md Outdated Show resolved Hide resolved

sarah11918 reviewed Jan 28, 2025

View reviewed changes

packages/astro/src/types/public/config.ts Show resolved Hide resolved

ascorbic and others added 3 commits January 28, 2025 12:24

Apply suggestions from code review

88f6d3f

Co-authored-by: Sarah Rainsberger <[email protected]>

Update .changeset/blue-spies-shave.md

3687e64

Co-authored-by: Sarah Rainsberger <[email protected]>

Add changeset for helper

11e2495

sarah11918 approved these changes Jan 28, 2025

View reviewed changes

Merge branch 'main' into trailing-magic

0fdb109

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: redirect trailing slashes on on-demand rendered pages #12994

feat: redirect trailing slashes on on-demand rendered pages #12994

ascorbic commented Jan 16, 2025 •

edited

Loading

changeset-bot bot commented Jan 16, 2025 •

edited

Loading

github-actions bot left a comment

codspeed-hq bot commented Jan 16, 2025 •

edited

Loading

ascorbic commented Jan 16, 2025

ematipico commented Jan 16, 2025 •

edited

Loading

ascorbic commented Jan 16, 2025

bluwy left a comment

ematipico commented Jan 16, 2025 •

edited

Loading

matthewp commented Jan 17, 2025

ascorbic commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

sarah11918 commented Jan 27, 2025

sarah11918 left a comment

ascorbic commented Jan 27, 2025

ascorbic commented Jan 27, 2025

ascorbic commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sarah11918 left a comment

feat: redirect trailing slashes on on-demand rendered pages #12994

Are you sure you want to change the base?

feat: redirect trailing slashes on on-demand rendered pages #12994

Conversation

ascorbic commented Jan 16, 2025 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Jan 16, 2025 • edited Loading

🦋 Changeset detected

github-actions bot left a comment

Choose a reason for hiding this comment

codspeed-hq bot commented Jan 16, 2025 • edited Loading

CodSpeed Performance Report

Merging #12994 will not alter performance

Summary

ascorbic commented Jan 16, 2025

ematipico commented Jan 16, 2025 • edited Loading

ascorbic commented Jan 16, 2025

bluwy left a comment

Choose a reason for hiding this comment

ematipico commented Jan 16, 2025 • edited Loading

matthewp commented Jan 17, 2025

ascorbic commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

sarah11918 commented Jan 27, 2025

sarah11918 left a comment

Choose a reason for hiding this comment

ascorbic commented Jan 27, 2025

ascorbic commented Jan 27, 2025

ascorbic commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sarah11918 left a comment

Choose a reason for hiding this comment

ascorbic commented Jan 16, 2025 •

edited

Loading

changeset-bot bot commented Jan 16, 2025 •

edited

Loading

codspeed-hq bot commented Jan 16, 2025 •

edited

Loading

ematipico commented Jan 16, 2025 •

edited

Loading

ematipico commented Jan 16, 2025 •

edited

Loading