Fixes attribute rendering for popover

[nanarino]

Changes

• Added popover to the list of boolean attributes

see: #11342 (comment)

Testing

Docs

[github-actions]

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

[codspeed-hq]

CodSpeed Performance Report

Merging #13037 will not alter performance

_{Comparing nanarino:main (5260983) with main (f576519)}

Summary

✅ 6 untouched benchmarks

[changeset-bot]

🦋 Changeset detected

Latest commit: 5260983

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nanarino]

I feel that my modification results in inconsistent behavior with other boolean attributes. This may require discussion.

[ematipico]

Suggested change

	---
	'astro': major
	---
	Fixes attribute rendering for `popover`
	---
	'astro': patch
	---
	Fixes attribute rendering for `popover`

[ematipico]

@nanarino can you please be more specific about your concerns?

[nanarino]

@nanarino can you please be more specific about your concerns?

null and undefined will definitely not be rendered; but for empty strings: popover={""} will be rendered; autofocus={""} will not, is confusing. It would be nice if the previous judgment was also changed to htmlBooleanAttributes.test(key) && typeof value === 'boolean', but this is a destructive update.