-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[v6] stabilize experimental.headingIdCompat #12510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but see my comment re: including how to build a custom rehype plugin inside this guide 😅
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Yan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny edits below, mostly based on I think that the big idea here is the change that people who have previously done nothing will face! Most people will now find themselves with heading id's autogenerated differently now (few will have been using the experimental flag, for example), and those are the people who need to realize that this affects them, and what they need to do specifically (which is probably updating links in their Markdown)
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description (required)
Related issues & labels (optional)
For Astro version:
6.0
. See astro PR #14494.