Skip to content

Conversation

louisescher
Copy link
Member

Description (required)

This PR includes some wording changes according to the new consensus reached in #12500: Islands are now no longer translated as "Inseln" in the German translation.

This PR is meant to act as a draft for German contributors to check out this change before we merge the updated guidelines.

@louisescher louisescher added i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest labels Oct 8, 2025
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e4284c8
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68ea89b5a82c3d00081feeca
😎 Deploy Preview https://deploy-preview-12523--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 8, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/concepts/islands.mdx Localization changed, will be marked as complete.
de/guides/migrate-to-astro/index.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@louisescher louisescher marked this pull request as ready for review October 9, 2025 14:03
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaut allgemein supi aus! 🙌

Ein paar Kleinigkeiten sind mir aufgefallen

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me know 🥳
We might want to retrigger the Netlify preview tho by updating the PR (should be fixed now) to see the changes live 👍

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, I went ahead and reverted the <h3> to ### change, it is supposed to be like that in the original to hide those headings from the "On this page"!

yanthomasdev

This comment was marked as duplicate.

@yanthomasdev yanthomasdev merged commit 101d064 into main Oct 11, 2025
10 checks passed
@yanthomasdev yanthomasdev deleted the de-con-isl branch October 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants