-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(de): update islands.mdx #12523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(de): update islands.mdx #12523
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schaut allgemein supi aus! 🙌
Ein paar Kleinigkeiten sind mir aufgefallen
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me know 🥳
We might want to retrigger the Netlify preview tho by updating the PR (should be fixed now) to see the changes live 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, I went ahead and reverted the <h3>
to ###
change, it is supposed to be like that in the original to hide those headings from the "On this page"!
Description (required)
This PR includes some wording changes according to the new consensus reached in #12500: Islands are now no longer translated as "Inseln" in the German translation.
This PR is meant to act as a draft for German contributors to check out this change before we merge the updated guidelines.