Skip to content

fix: update install-and-setup.mdx #12542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 15, 2025
Merged

fix: update install-and-setup.mdx #12542

merged 7 commits into from
Oct 15, 2025

Conversation

@vrabe
Copy link
Contributor

@vrabe vrabe commented Oct 12, 2025 •
edited
Loading

Description (required)

Update install-and-setup.mdx.

It seems that the space is intended? I'm not sure it's correct to remove the space.

I'm also not sure it's correct to add the <ReadMore> component or not.

Related issues & labels (optional)

  • Closes #
  • Suggested label: typo/link/grammar - quick fix!

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 12, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/install-and-setup.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link

netlify bot commented Oct 12, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bb0493
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68efb548e250ab00086fd9f2
😎 Deploy Preview https://deploy-preview-12542--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

yanthomasdev
yanthomasdev reviewed Oct 12, 2025
View reviewed changes
src/content/docs/en/install-and-setup.mdx
}
```

Read Astro's [TypeScript setup guide](/en/guides/typescript/#setup) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this line should also have <ReadMore>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it.

sarah11918
sarah11918 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good for consistency. Thank you!

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Oct 15, 2025
yanthomasdev
yanthomasdev approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit 8f7965a into withastro:main Oct 15, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 15, 2025
@ArmandPhilippot
i18n(fr): update install-and-setup.mdx
1d92d4e 
See withastro#12542
@ArmandPhilippot ArmandPhilippot mentioned this pull request Oct 15, 2025
Merged
@vrabe vrabe deleted the update-install-setup branch October 15, 2025 17:31
@vrabe vrabe mentioned this pull request Oct 15, 2025
Merged
@jsparkdev jsparkdev mentioned this pull request Oct 16, 2025
Merged
@Nin3lee Nin3lee mentioned this pull request Oct 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrabe @astrobot-houston @sarah11918 @yanthomasdev