Open
Conversation
std_thread_test doesn’t compile with the macOS 12 SDK due to conflicts with the native std::thread implementation. As this functionality is deprecated anyway, just disable the test.
…r with different allocator type" The function is deprecated, so removal should not pose a problem. This fixes a compiler error in Visual Studio 2017
The explicit invocation of ${CMAKE_CXX_COMPILER} to generate lists of
exported symbols was not taking into account the target architecture;
instead it would inherit whatever architecture was running the actual
build process. This could cause missing symbol errors when building the
macOS arm64 target from an x86_64 shell session.
There was a quoting error in fd76ffb which meant the space between -arch and the architecture was escaped. Also this commit adds the stdlib argument to suppress a warning about the failure to find libstdc++, which has not been available on macOS for some time.
Newer GCCs do not allow the meaning of "task" to change in the scope of a class declaration, which is apparently invalid C++.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge TBB 2020 Update 3 from the official repo. Also, std_thread_test does not compile on macOS 12 and has been commented out as it is deprecated.