Reducing deployment target #17
Conversation
|
Thanks! We actually need to make CI work on those versions, too. In order to accomplish that we need to tweak Travis setup. It is currently being changed in #16 so I'd wait until it's merged. Thanks again. I'll notify you when the other PR is merged. |
|
Just rebased, I see that the other PR has already reduced the xcodeproj targets, so it will just for CocoaPods! Travis up to date too, I added all the os destinations supported by |
|
Any ideas why the iOS10+ targets are failing? 🤔 |
|
If you view the raw log on Travis you can see that it failed because of a timeout. I saw some discussions about it online but can't find them anymore. @tbaranes. If you can't find them I'll do my best to fix it over the weekend |
|
Yeah, you're looking for this: travis-ci/travis-ci#4725 At the bottom of after_success:
- bash <(curl -s https://codecov.io/bash)
- sleep 5 # Workaround for https://github.com/travis-ci/travis-ci/issues/4725 |
|
Right, I already see that kind of issue on others projects. |
| after_success: | ||
| - bash <(curl -s https://codecov.io/bash) | ||
| - sleep 5 # Workaround for https://github.com/travis-ci/travis-ci/issues/4725 |
There was a problem hiding this comment.
Just a small note - please ensure there are newlines at the end of all of your files.
Otherwise, all 👍
Current coverage is 93.23% (diff: 100%)
|
|
Awesome @tbaranes. Thanks a lot! |
That framework looks really great, but the deployment target is quiet hight for my projects 😬
So, I updated (for carthage and CocoaPods) them to:
Is there any reasons to have higher version? I didn't see any regressions by running the tests / launching the example.