Skip to content

Remove useless _add method #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
est wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove useless _add method #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6b64c
fix: typo
est Apr 22, 2026
7521fc3
del: dead _add code in object.py
est Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion genson/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def __init__(self, prog=None):

def run(self):
if not self.args.schema and not self.args.object:
self.fail('noting to do - no schemas or objects given')
self.fail('nothing to do - no schemas or objects given')
self.add_schemas()
self.add_objects()
self.print_output()
Expand Down
7 changes: 0 additions & 7 deletions genson/schema/strategies/object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,6 @@ def _matching_pattern(self, prop):
if search(pattern, prop):
return pattern

def _add(self, items, func):
while len(self._items) < len(items):
self._items.append(self._schema_node_class())

for subschema, item in zip(self._items, items):
getattr(subschema, func)(item)

def to_schema(self):
schema = super().to_schema()
schema['type'] = 'object'
Expand Down