Update ChainmonstersRewards contract to allow reward metadata updates#5
Draft
maggo wants to merge 2 commits into
Draft
Update ChainmonstersRewards contract to allow reward metadata updates#5maggo wants to merge 2 commits into
maggo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pub fun updateRewardMetadata(rewardID: UInt32, metadata: String)on the Admin resourcepub let metadata: Stringtopub var metadata: Stringand addsaccess(contract) fun setMetadata(metadata: String)on the Reward to make the metadata updateableupdate_reward_metadata.cdctransaction as an exampleAlso converted all indentation to spaces and removed trailing whitespace for readability ;)
For better diff:
https://github.com/bsidegames/chainmonsters-smart-contracts/pull/5/files?w=1