[POS as a Tab] Tab & Visibility #14183

toupper · 2025-06-12T10:07:42Z

Description

With this PR, we add a tab for POS and show it when:

Woo POS is enabled (same conditions previously used in the menu)
The feature flag for "POS as a Tab" is enabled

When visibility is updated

We update the POS tab visibility in the following cases:

On app startup and when returning from the background
When the active site changes
On user login

Navigation behavior

When the POS tab is tapped:

The POS screen is launched
The bottom navigation bar is hidden
The tab is not visually selected (since it transitions to a new Activity)

Steps to reproduce

On app startup and coming to foreground, when logged in

Open the app with a site where POS is enabled. The tab should be visible.
Open the app with a site where POS is not enabled. The tab should not be visible.

On site changed

Change your site in menu and check that the tab visibility is updated according to the the new site POS availability.

On login

Login and check that the tab visibility is shoen according to the the login site POS availability.

Testing information

See above

The tests that have been performed

See above

Images/gif

Switching sites

Screen_Recording_20250612_095737_Woo.Pre-Alpha.mp4

Login

Screen_Recording_20250612_095852_Woo.Pre-Alpha.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

…a-tab-visibility

dangermattic · 2025-06-12T10:08:34Z

	2 Warnings
⚠️	Class `WooPosIsPosAsTabEnabled` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `WooPosTabController` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2025-06-12T10:13:06Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`4c96fc5`
	Direct Download	`woocommerce-wear-prototype-build-pr14183-4c96fc5.apk`

wpmobilebot · 2025-06-12T10:25:38Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`4c96fc5`
	Direct Download	`woocommerce-prototype-build-pr14183-4c96fc5.apk`

jaclync · 2025-06-13T06:22:36Z

@toupper Nice progress with small amount of changes! From the screencasts, it looks like the POS tab is displayed right after logging in / switching stores, is it because it's shown by default, or the eligibility check results are cached for each connected site? Or the internet was so fast that all API calls from site settings (for store country/currency), remote feature flag, active plugins just returned with minimal delay?

In iOS, I'm exploring ways to optimize the POS eligibility check for the POS tab so that we can show the tab as soon as possible. This includes caching the eligibility result for each site for like 3 days in WOOMOB-599.

Copilot

Pull Request Overview

This PR adds a “Point of Sale” tab to the bottom navigation, controlled by a feature flag and POS availability, and integrates its visibility and navigation handling into the main activity.

Adds a new string and menu item for the POS tab
Introduces WooPosTabController & feature-flag helper
Integrates setup and visibility refresh into MainActivity

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
WooCommerce/src/main/res/values/strings.xml	Added `point_of_sale` string
WooCommerce/src/main/res/menu/menu_bottom_bar.xml	Added POS menu item entry
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosTabController.kt	New controller managing POS tab visibility & navigation
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosIsPOSAsATabEnabled.kt	Added feature-flag helper for POS tab
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt	Injected and wired up POS tab controller calls

Comments suppressed due to low confidence (2)

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosIsPOSAsATabEnabled.kt:6

[nitpick] The class name is verbose and repeats 'POS'. Consider renaming to IsWooPosTabEnabled or WooPosTabEnabledChecker for clarity and consistency with other feature-flag helpers.

class WooPosIsPOSAsATabEnabled @Inject constructor() {

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosTabController.kt:51

There are no unit tests covering the visibility logic in refreshPOSTabVisibility and updatePOSTabVisibility. Consider adding tests to verify the tab shows and hides correctly based on feature flag and POS availability.

fun refreshPOSTabVisibility() {

Copilot · 2025-06-13T06:30:12Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

@@ -388,6 +394,8 @@ class MainActivity :
        // Track if App was opened from a widget
        trackIfOpenedFromWidget()

+        posTabController.refreshPOSTabVisibility()


To handle returning from background and app resume events, consider calling refreshPOSTabVisibility() in onResume or onStart rather than only during onCreate, matching the intended visibility update triggers.

Copilot · 2025-06-13T06:30:12Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosTabController.kt

+        binding.bottomNav.setOnItemSelectedListener { item ->
+            when (item.itemId) {
+                R.id.point_of_sale -> {
+                    activity.startActivity(Intent(activity, WooPosActivity::class.java))
+                    false // return false to *not* keep the tab selected
+                }
+                else -> NavigationUI.onNavDestinationSelected(item, navController)


[nitpick] Overriding the entire BottomNavigation listener may unintentionally remove existing behaviors. Consider preserving the original listener for non-POS items or wrapping it so you only inject your POS case.

Suggested change

binding.bottomNav.setOnItemSelectedListener { item ->

when (item.itemId) {

R.id.point_of_sale -> {

activity.startActivity(Intent(activity, WooPosActivity::class.java))

false // return false to *not* keep the tab selected

}

else -> NavigationUI.onNavDestinationSelected(item, navController)

val originalListener = binding.bottomNav.onItemSelectedListener

binding.bottomNav.setOnItemSelectedListener { item ->

when (item.itemId) {

R.id.point_of_sale -> {

activity.startActivity(Intent(activity, WooPosActivity::class.java))

false // return false to *not* keep the tab selected

}

else -> {

originalListener?.onNavigationItemSelected(item)

NavigationUI.onNavDestinationSelected(item, navController)

}

malinajirka

@toupper Great job, the PR seems short but I'm sure this one was tricky to figure out!

I haven't tested the app yet as I left a few comments which might result in changes and a need for a re-test. Let me know what you think about them - the only one I believe we should fix is the database access on the UI thread, the others are more of a food for thought.

malinajirka · 2025-06-13T06:33:03Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosIsPOSAsATabEnabled.kt

+import com.woocommerce.android.util.FeatureFlag
+import javax.inject.Inject
+
+class WooPosIsPOSAsATabEnabled @Inject constructor() {


🔍 POS might be cleaner with camel case Pos. I'd also consider dropping the article A, we usually don't include it in the names even though it's dramatically incorrect => WooPosIsPosAsTabEnabled. Wdyt?

Good point, done in e0769c1

malinajirka · 2025-06-13T06:44:06Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosTabController.kt

+
+    private fun updatePOSTabVisibility() {
+        activity.lifecycleScope.launch {
+            setPOSTabVisibility(isWooPosEnabled())


⚠️ This is not a flaw of this PR, but if my evaluation is correct, I think we should fix it here. I believe this code will start a coroutine on the main/UI thread. The isWooPosEnabled method should take care of switching context for long running operations, but it doesn't. For example GetWooCorePluginCachedVersion doesn't change the dispatcher and it hits the database. Similarly woocommerceStore.getSiteSettings also hits the database.

I see three options:

Change the coroutine context here to the IO dispatcher.

Change the coroutine context in the WooPosIsEnabled.invoke(). (The solution I'd personally go with here)

Or the most correct but the most time consuming approach, update all the coresponding sites and change the context as close to the time consuming operation as possible (eg. right before we hit the database).

Wdyt? Have I missed something or it truly runs on the UI thread?

Good point, I implemented option 2 in 2aab706

malinajirka · 2025-06-13T06:46:15Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

@@ -388,6 +394,8 @@ class MainActivity :
        // Track if App was opened from a widget
        trackIfOpenedFromWidget()

+        posTabController.refreshPOSTabVisibility()


💡 I think we might want to consider registering the WooPosTabController to the activity lifecycle and calling this method within the WooPosTabController. I think we should be able to move there even the two methods we invoke in onCreate, ultimately keeping the MainActivity completely clean of the controller's logic -> all the logic would be in the controller and the only code in the activity would be the registration for the lifecycle. Wdyt?

That's great, I didn't know about that, thanks a lot! Done in a75db86

malinajirka · 2025-06-13T06:47:52Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

@@ -725,6 +733,7 @@ class MainActivity :
        )
        finish()
        startActivity(intent)
+        posTabController.refreshPOSTabVisibility()


❓ Honest question as I haven't tested this and I'm not sure. Is this truly necessary even though we invoke the same method in onResume? I'd expect both onCreate and onResume should be called when we finish the activity and start a new one 🤔.

Indeed that works, done in a75db86

…o be called manually from MainActivity

…ther POS is enabled

toupper · 2025-06-16T13:59:52Z

Thanks for your message @jaclync!

Nice progress with small amount of changes! From the screencasts, it looks like the POS tab is displayed right after logging in / switching stores, is it because it's shown by default, or the eligibility check results are cached for each connected site?

It was still showing the previous value, but that wasn't correct, so I implement hiding it by default here a4decdf. In next PRs we can consider caching the value as you suggested.

jaclync · 2025-06-17T06:38:51Z

It was still showing the previous value, but that wasn't correct, so I implement hiding it by default here a4decdf. In next PRs we can consider caching the value as you suggested.

Got it, I created an issue for caching the eligibility value in Android in WOOMOB-620.

malinajirka

@toupper Thanks for the changes, I believe the encapsulation will help with long-term maintenance. However, the performance changes seem to be affecting the behavior - there is some race condition. The Tab isn't visible after login or after (some) site switches.

I added some logs and it seems the WooIsPosEnabled doesn't have access to the site settings and therefore returns false:

11:44:25.734  D  WooPosTabController: POS as tab enabled, updating visibility
11:44:25.734  D  WooPosTabController: updatePOSTabVisibility - checking isWooPosEnabled
11:44:25.734  D  WooPosIsEnabled: checking if POS is enabled
11:44:25.748  D  WooPosIsEnabled: WooCommerce version 9.8.5 supports product filtering: true
11:44:25.753  D  WooPosIsEnabled: WooCommerce version 9.8.5 supports feature switch: false
11:44:25.755  D  WooPosIsEnabled: Failed - couldn't retrieve site settings
11:44:25.824  D  WooPosTabController: isWooPosEnabled returned: false
11:44:25.824  D  WooPosTabController: Setting POS tab visibility to false
11:44:25.824  D  WooPosTabController: POS menu item found: true, visibility set to false

It seems it currently loads the siteSettings from the local cache and if it's not there, it fails. I think we might need to either add some delay and check if the site settings is available after the delay and/or fetch the site settings if they are not available.

This issue was likely present even before, but it was almost impossible to reproduce since the user would need to switch to More menu very quickly, before the siteSettings request finishes.

Patch with logs
Logs_for_POS_tab.patch

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/tab/WooPosTabController.kt

toupper added 11 commits June 10, 2025 16:26

Showing POS in a tab POC

560dd1c

Merge branch 'toupper/pos_as_a_tab_poc' into issue/WOOMOB-569-pos-as-…

503fb86

…a-tab-visibility

Extract functionality to its own class

0561ae0

Apply Feature Flag

7ca2070

Move Feature Flag check to its own class

2764dcd

Revert previous changes from presenter and contract

63db318

Revert empty line removal

661ef37

Automatic change

0647ffe

Clean code

7904fd4

Refactor to call to refresh pos tab visibility on resume

ebcdefc

Rename file for detekt

7efd555

toupper added this to the 22.7 milestone Jun 12, 2025

toupper requested a review from malinajirka June 12, 2025 10:07

toupper added type: task An internally driven task. feature: POS labels Jun 12, 2025

toupper changed the title ~~Issue/woomob 569 pos as a tab visibility~~ [POS as a Tab] Tab & Visibility Jun 12, 2025

malinajirka self-assigned this Jun 13, 2025

malinajirka requested a review from Copilot June 13, 2025 06:28

Copilot AI reviewed Jun 13, 2025

View reviewed changes

malinajirka reviewed Jun 13, 2025

View reviewed changes

malinajirka mentioned this pull request Jun 13, 2025

[POS as a Tab] Remove POS entry point from Menu #14185

Open

1 task

toupper added 5 commits June 16, 2025 13:34

Better naming

e0769c1

Rename file too

944bc25

Register the WooPosTabController to the lifecycle instead of having t…

a75db86

…o be called manually from MainActivity

Run blocking code in the background.

2aab706

Hide the POS Tab by default to avoid tapping there while checking whe…

a4decdf

…ther POS is enabled

toupper added the unit-tests-exemption label Jun 16, 2025

toupper requested a review from malinajirka June 17, 2025 06:35

malinajirka requested changes Jun 17, 2025

View reviewed changes

Remove non necessary comments

4c96fc5

[POS as a Tab] Tab & Visibility #14183

Are you sure you want to change the base?

[POS as a Tab] Tab & Visibility #14183

Conversation

toupper commented Jun 12, 2025

Description

When visibility is updated

Navigation behavior

Steps to reproduce

On app startup and coming to foreground, when logged in

On site changed

On login

Testing information

The tests that have been performed

Images/gif

Switching sites

Login

Uh oh!

dangermattic commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaclync commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka left a comment

Choose a reason for hiding this comment

Uh oh!

malinajirka Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

toupper Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toupper Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

toupper Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

toupper Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

toupper commented Jun 16, 2025

Uh oh!

jaclync commented Jun 17, 2025

Uh oh!

malinajirka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dangermattic commented Jun 12, 2025 •

edited

Loading

wpmobilebot commented Jun 12, 2025 •

edited

Loading

wpmobilebot commented Jun 12, 2025 •

edited

Loading

jaclync commented Jun 13, 2025 •

edited

Loading

malinajirka Jun 13, 2025 •

edited

Loading

malinajirka left a comment •

edited

Loading