-
Notifications
You must be signed in to change notification settings - Fork 135
[WOOMOB-1648] Add tablet screenshot infrastructure for Woo POS #14948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[WOOMOB-1648] Add tablet screenshot infrastructure for Woo POS #14948
Conversation
| ##################################################################################### | ||
| desc 'Create raw POS screenshots for tablets' | ||
| lane :take_pos_screenshots do |options| | ||
| locales = options[:locales] || ['en-US', 'en-GB'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 🚫 | Style/WordArray: Use %w or %W for an array of words. |
| lane :take_pos_screenshots do |options| | ||
| locales = options[:locales] || ['en-US', 'en-GB'] | ||
|
|
||
| UI.message("Clearing previous POS screenshots...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| locales = options[:locales] || ['en-US', 'en-GB'] | ||
|
|
||
| UI.message("Clearing previous POS screenshots...") | ||
| sh("rm -f ../fastlane/screenshots/raw/*-pos-*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| UI.message("Clearing previous POS screenshots...") | ||
| sh("rm -f ../fastlane/screenshots/raw/*-pos-*") | ||
|
|
||
| UI.message("Building APKs...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
WOOMOB-1648
Description
Adds infrastructure for capturing screenshots on tablets for Woo POS testing. This includes updates to the screenshot test suite and Fastlane configuration to support tablet devices.
Test Steps
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.