Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Request Buttons - Wrong Sizing #3989

Open
mattthomasphoto opened this issue Feb 26, 2025 · 0 comments · May be fixed by #4021
Open

Payment Request Buttons - Wrong Sizing #3989

mattthomasphoto opened this issue Feb 26, 2025 · 0 comments · May be fixed by #4021
Assignees

Comments

@mattthomasphoto
Copy link

mattthomasphoto commented Feb 26, 2025

Describe the bug
It seems that in 9.2.0 the payment request buttons now for some reason don’t take up 100% width of their container, which prevents a styling mismatch between the normal add to cart button and the ECE buttons

It’s to do with the change in the file

/build/express_checkout.css

As now it’s including all this

#wc-stripe-express-checkout-element iframe {
max-width:unset
}

#wc-stripe-express-checkout-element {
margin-bottom:12px;
display:flex;
gap:10px;
flex-wrap:wrap;
justify-content:center
}

Whereas previously all that was there had nothing to do with the display flex or wrap

https://github.com/woocommerce/woocommerce-gateway-stripe/blob/6b6cf5010dbdcf50c050e8909a52a6b032c02d11/client/entrypoints/express-checkout/styles.scss

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'any product page where there is just GPay and Apple Pay or checkout'
  2. Click on '....'
  3. Scroll down to 'payment request button and see the smaller sizing now because of the styling'
  4. See error

Expected behavior
Buttons to be full width as no AmazonPay is in the UK so all UK stores have this styling issuing due to the new wrap that's been added

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • WordPress Version - 6.7.2
  • WooCommerce Version - 9.7.0
  • Stripe Plugin Version - 9.2.0
  • Browser [e.g. chrome, safari] and Version - any browser as it's just linked to the new styling add for Amazon Pay
  • Any other plugins installed

Additional context
Topic first mentioned here - https://wordpress.org/support/topic/9-2-0-payment-buttons-not-100-width-size/

@Mayisha Mayisha self-assigned this Mar 6, 2025
@Mayisha Mayisha linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants