Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECE button size in shortcode cart page #4021

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Mar 6, 2025

Fixes #3989

Changes proposed in this Pull Request:

  • Added flex: 1 and min-width so that each ECE button takes up the available space in the container.

Testing instructions

  • Enable Google/Apple Pay, Link and Amazon Pay.
  • Add a product to your cart and go to the shortcode cart page.
  • In develop notice that the buttons are not taking full width.
Screenshot 2025-03-06 at 9 42 19 PM
  • In this branch, confirm that the buttons are full width and aligned with the proceed to checkout button.
Screenshot 2025-03-06 at 9 41 44 PM
  • Confirm that the buttons are rendering nicely in both shortcode cart and checkout pages for different window width.

@Mayisha Mayisha requested review from a team and hsingyuc and removed request for a team March 6, 2025 17:14
Copy link
Contributor

@hsingyuc hsingyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mayisha, can you confirm whether you also see the gaps between the ECE buttons in Blocks cart page in Safari?
Screenshot 2025-03-08 at 9 12 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Request Buttons - Wrong Sizing
2 participants