Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_order_from_intent to use charges->data #3873

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joshtwc
Copy link

@joshtwc joshtwc commented Feb 12, 2025

Fixes #

Changes proposed in this Pull Request:

Webhook data for charges has key data, this change just checks if $charges is array then gets the data from the sub-key 'data' instead.

If the webhook changes to have charges as neither an object (with key data) or an array of charges, it may throw an error.

Testing instructions

Forward webhooks to your site, then complete a payment with the gateway. When payment_intent.succeeded webhook sends, it should not give a fatal error.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant