Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable dump in ACH customer error message when retrying a payment #4039

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rafaelzaleski
Copy link
Contributor

Fixes #3991

Changes proposed in this Pull Request:

This PR removes the variable dump in the ACH customer error message when retrying a payment.

Testing instructions

  1. Reproduce the bug in develop by following the instructions in ACH: Raw variable dump appears in customer error message when retrying a payment #3991.
  2. Switch to this PR and repeat the steps in ACH: Raw variable dump appears in customer error message when retrying a payment #3991.
  3. The customer error message should no longer contain the variable found in step 1.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Fix customer error message when retrying a payment with ACH.

Comment

Post merge

@rafaelzaleski rafaelzaleski changed the title Remove variable dump in ACH customer error message when retrying a payment Fix variable dump in ACH customer error message when retrying a payment Mar 11, 2025
@rafaelzaleski rafaelzaleski self-assigned this Mar 11, 2025
@rafaelzaleski
Copy link
Contributor Author

The charge_exceeds_source_limit error is intended for merchants, not shoppers. I’ve created #4046 to refactor the WC_Stripe_Exception class to better handle the messages we display for shoppers and merchants.

@rafaelzaleski rafaelzaleski marked this pull request as ready for review March 12, 2025 15:13
@rafaelzaleski rafaelzaleski requested review from a team and asumaran and removed request for a team March 12, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACH: Raw variable dump appears in customer error message when retrying a payment
1 participant