Fix fatal error with PRB buttons #4042
Open
+34
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes a possible fatal error happening when a product cannot be found, related to PRBs' add to cart ajax endpoint. This error was caught with Grafana:
On a regular store setup, this error should not happen since we deprecated PRBs in favor of express payment methods. But this change should at least make the code safer.
Testing instructions
Code review should be enough. Check if the tests are still passing.
Changelog entry
Changelog Entry Comment
Comment
Post merge