Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment method name for the pay for order page #4047

Open
wants to merge 2 commits into
base: add/spe-classic-checkout-implementation
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Mar 12, 2025

Changes proposed in this Pull Request:

This PR fixes the payment method label for orders paid using the Pay for Order page. #4036 broke it with the change to the container title. I am removing the container title to fix the issue, which is not a big deal since we will hide the title and the container borders in #3896

Testing instructions

  • Checkout and build this branch on your test environment (fix/order-pay-for-order-payment-method-name)
  • Connect your Stripe account
  • Copy your child payment method configuration ID from here: https://dashboard.stripe.com/settings/payment_methods (labeled "Your configuration")
  • Insert the ID above on client/classic/upe/payment-processing.js:136. This is temporary until the parent configuration, labeled WooCommerce Inc., supports all methods by default
  • Build the frontend files (npm run build:webpack)
  • Enable the SPE feature flag (_wcstripe_feature_spe). You can do it by either hardcoding the return value of is_spe_available to true or by running npm run wp option update _wcstripe_feature_spe 'yes'
  • As a merchant, disable the legacy checkout experience in settings (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=settings)
  • Enable the Single Payment Element feature
  • Create a new order in a pending payment state
  • As the order owner, try to pay for the order
  • Confirm the order payment method is correctly identified.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Mar 12, 2025
@wjrosa wjrosa marked this pull request as ready for review March 12, 2025 19:12
@wjrosa wjrosa requested review from a team and diegocurbelo and removed request for a team March 12, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant