Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Dec 4, 2025

Changes proposed in this Pull Request:

In this cleaning-up PR, I am removing all references to the UPE-enabled feature flag, related code, and the promotional banners that were shown only for the legacy checkout.

I am also updating the rendering logic for the order customization notice according to the discussion in #4846 (comment)

Testing instructions

Code review. Check if the tests are still passing. You can also perform some basic smoke-testing on the frontend.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Dec 4, 2025
@wjrosa wjrosa marked this pull request as ready for review December 4, 2025 16:48
@wjrosa wjrosa changed the title Removing the UPE enabled flag references from the frontend Removing the UPE enabled flag references from the frontend + deprecated banners Dec 4, 2025
@wjrosa wjrosa requested review from a team, Mayisha and malithsen and removed request for a team December 4, 2025 16:57
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments from code review.

✅ Settings page looks good.
✅ Storefront looks good.
✅ Tested payment with card, CashApp and GPay.
⚠️ I had a GB account connected with store currency GBP and AliPay was offered in the checkout page with the following error. Probably unrelated to this PR but documenting here as discovered during smoke testing.

Screenshot 2025-12-08 at 12 49 56 PM

⚠️ A few JS tests are failing.

@wjrosa wjrosa requested a review from Mayisha December 8, 2025 15:23
@wjrosa
Copy link
Contributor Author

wjrosa commented Dec 8, 2025

Thanks for the review, Mayisha! I addressed all the issues, and fixed the unit tests

Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tests look good.

} );

it( 'should toggle the flag when UPE is enabled', async () => {
it( 'should toggle the flag when', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incomplete, let's update the test name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants