-
Notifications
You must be signed in to change notification settings - Fork 215
Removing the UPE enabled flag references from the frontend + deprecated banners #4846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Removing the UPE enabled flag references from the frontend + deprecated banners #4846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments from code review.
✅ Settings page looks good.
✅ Storefront looks good.
✅ Tested payment with card, CashApp and GPay.
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
…of github.com:woocommerce/woocommerce-gateway-stripe into dev/removing-upe-enabled-references-from-the-frontend
|
Thanks for the review, Mayisha! I addressed all the issues, and fixed the unit tests |
Mayisha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
malithsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests look good.
| } ); | ||
|
|
||
| it( 'should toggle the flag when UPE is enabled', async () => { | ||
| it( 'should toggle the flag when', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks incomplete, let's update the test name
Changes proposed in this Pull Request:
In this cleaning-up PR, I am removing all references to the UPE-enabled feature flag, related code, and the promotional banners that were shown only for the legacy checkout.
I am also updating the rendering logic for the order customization notice according to the discussion in #4846 (comment)
Testing instructions
Code review. Check if the tests are still passing. You can also perform some basic smoke-testing on the frontend.
Changelog entry
Changelog Entry Comment
Comment
Post merge