Skip to content

Add Restore and Download Backup buttons to ActivityLogDetailsView #24600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 19, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 19, 2025

  • Add "Restore" and "Download" button to the new ActivityLogDetailsView.swift
  • Fix an issue with content in "Restore" and "Download Backup" flows covering the navigation bar
  • Add missing analytics events
  • Extract reusable CardView and InfoRow components from SubscribersDetailsView
  • Add .claude/settings.local.json to .gitignore
backups-flow.mov
Screenshot 2025-06-19 at 4 38 55 PM

@kean kean added this to the 26.0 milestone Jun 19, 2025
@kean kean changed the base branch from trunk to feature/jetpack-activity-logs June 19, 2025 19:13
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 19, 2025

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@@ -20,7 +20,7 @@ struct ActivityLogRowViewModel: Identifiable {
self.activity = activity
self.id = activity.activityID
if let actor = activity.actor {
if actor.role.isEmpty {
if !actor.role.isEmpty {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo from previous PR. Typo in code I wrote myself 😮‍💨

Copy link

@kean kean merged commit 0e67f85 into feature/jetpack-activity-logs Jun 19, 2025
12 of 31 checks passed
@kean kean deleted the task/backups branch June 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants